Skip to content

Commit

Permalink
[dart2js] Added a powerset flag for new experiment
Browse files Browse the repository at this point in the history
This experiment will use a powerset abstract value domain in the inferrer


Change-Id: I216ff9c24d1e7292688426ae7bcb52b15aa2714e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/153720
Reviewed-by: Stephen Adams <sra@google.com>
Commit-Queue: Christian Altamirano <coam@google.com>
  • Loading branch information
Christian Altamirano authored and commit-bot@chromium.org committed Jul 9, 2020
1 parent 5580f89 commit 4f66bb0
Show file tree
Hide file tree
Showing 4 changed files with 12 additions and 3 deletions.
2 changes: 2 additions & 0 deletions pkg/compiler/lib/src/commandline_options.dart
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,8 @@ class Flags {
static const String experimentalAllocationsPath =
'--experimental-allocations-path';

static const String experimentalPowersets = '--experimental-powersets';

// Temporary experiment for code generation of locals for frequently used
// 'this' and constants.
static const String experimentLocalNames = '--experiment-code-1';
Expand Down
8 changes: 5 additions & 3 deletions pkg/compiler/lib/src/compiler.dart
Original file line number Diff line number Diff line change
Expand Up @@ -135,9 +135,11 @@ abstract class Compiler {
options.deriveOptions();
options.validate();

abstractValueStrategy = options.useTrivialAbstractValueDomain
? const TrivialAbstractValueStrategy()
: const TypeMaskStrategy();
abstractValueStrategy = options.experimentalPowersets
? throw UnimplementedError('Powerset abstract value domain')
: options.useTrivialAbstractValueDomain
? const TrivialAbstractValueStrategy()
: const TypeMaskStrategy();
CompilerTask kernelFrontEndTask;
selfTask = new GenericTask('self', measurer);
_outputProvider = new _CompilerOutput(this, outputProvider);
Expand Down
1 change: 1 addition & 0 deletions pkg/compiler/lib/src/dart2js.dart
Original file line number Diff line number Diff line change
Expand Up @@ -445,6 +445,7 @@ Future<api.CompilationResult> compile(List<String> argv,
new OptionHandler(Flags.disableProgramSplit, passThrough),
new OptionHandler(Flags.disableTypeInference, passThrough),
new OptionHandler(Flags.useTrivialAbstractValueDomain, passThrough),
new OptionHandler(Flags.experimentalPowersets, passThrough),
new OptionHandler(Flags.disableRtiOptimization, passThrough),
new OptionHandler(Flags.terse, passThrough),
new OptionHandler('--deferred-map=.+', passThrough),
Expand Down
4 changes: 4 additions & 0 deletions pkg/compiler/lib/src/options.dart
Original file line number Diff line number Diff line change
Expand Up @@ -193,6 +193,9 @@ class CompilerOptions implements DiagnosticOptions {
/// Whether to use the trivial abstract value domain.
bool useTrivialAbstractValueDomain = false;

/// Whether to use the powerset abstract value domain (experimental).
bool experimentalPowersets = false;

/// Whether to disable optimization for need runtime type information.
bool disableRtiOptimization = false;

Expand Down Expand Up @@ -428,6 +431,7 @@ class CompilerOptions implements DiagnosticOptions {
..disableTypeInference = _hasOption(options, Flags.disableTypeInference)
..useTrivialAbstractValueDomain =
_hasOption(options, Flags.useTrivialAbstractValueDomain)
..experimentalPowersets = _hasOption(options, Flags.experimentalPowersets)
..disableRtiOptimization =
_hasOption(options, Flags.disableRtiOptimization)
..dumpInfo = _hasOption(options, Flags.dumpInfo)
Expand Down

0 comments on commit 4f66bb0

Please sign in to comment.