Skip to content

Commit

Permalink
[cfe] Use test description uri for expectation file location
Browse files Browse the repository at this point in the history
Previously the first file in the `Component.uriToSource` was used which
didn't work nicely with multifile tests.

Text outline expectations were already using the test description uri.

Change-Id: I0d4a7493cd1fa61beffba41f1ea859ca5e8ad08c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/151825
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Jens Johansen <jensj@google.com>
  • Loading branch information
johnniwinther authored and commit-bot@chromium.org committed Jul 6, 2020
1 parent fa650e4 commit 3a4aad6
Show file tree
Hide file tree
Showing 48 changed files with 87 additions and 527 deletions.
3 changes: 1 addition & 2 deletions pkg/front_end/test/utils/kernel_chain.dart
Original file line number Diff line number Diff line change
Expand Up @@ -257,8 +257,7 @@ class MatchExpectation
component.adoptChildren();
}

Uri uri =
component.uriToSource.keys.firstWhere((uri) => uri?.scheme == "file");
Uri uri = result.description.uri;
Iterable<Library> libraries =
componentToText.libraries.where(result.isUserLibrary);
Uri base = uri.resolve(".");
Expand Down

This file was deleted.

This file was deleted.

This file was deleted.

Loading

0 comments on commit 3a4aad6

Please sign in to comment.