From df074fb48e439ed5572894676f7ed7aa5d05986f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Istv=C3=A1n=20So=C3=B3s?= Date: Wed, 13 Dec 2023 14:01:12 +0100 Subject: [PATCH] Verify in tests that alt="" does not contain element type. (#7300) --- app/lib/frontend/dom/dom.dart | 2 ++ .../templates/views/pkg/score_tab.dart | 2 +- .../templates/views/shared/search_banner.dart | 4 +-- .../templates/views/shared/site_header.dart | 2 +- app/test/frontend/golden/authorized_page.html | 6 ++-- app/test/frontend/golden/consent_page.html | 6 ++-- .../golden/create_publisher_page.html | 6 ++-- app/test/frontend/golden/error_page.html | 6 ++-- app/test/frontend/golden/help_page.html | 6 ++-- app/test/frontend/golden/landing_page.html | 6 ++-- .../frontend/golden/my_activity_log_page.html | 6 ++-- .../frontend/golden/my_liked_packages.html | 6 ++-- app/test/frontend/golden/my_packages.html | 6 ++-- app/test/frontend/golden/my_publishers.html | 6 ++-- .../golden/pkg_activity_log_page.html | 6 ++-- app/test/frontend/golden/pkg_admin_page.html | 6 ++-- .../frontend/golden/pkg_changelog_page.html | 6 ++-- .../frontend/golden/pkg_example_page.html | 6 ++-- app/test/frontend/golden/pkg_index_page.html | 10 +++--- .../frontend/golden/pkg_install_page.html | 6 ++-- app/test/frontend/golden/pkg_score_page.html | 10 +++--- app/test/frontend/golden/pkg_show_page.html | 6 ++-- .../golden/pkg_show_page_discontinued.html | 6 ++-- .../golden/pkg_show_page_flutter_plugin.html | 6 ++-- .../golden/pkg_show_page_publisher.html | 6 ++-- .../golden/pkg_show_page_retracted.html | 6 ++-- ..._page_retracted_non_retracted_version.html | 6 ++-- .../golden/pkg_show_version_page.html | 6 ++-- .../frontend/golden/pkg_versions_page.html | 6 ++-- .../golden/publisher_activity_log_page.html | 6 ++-- .../frontend/golden/publisher_admin_page.html | 6 ++-- .../frontend/golden/publisher_list_page.html | 10 +++--- .../golden/publisher_packages_page.html | 6 ++-- .../publisher_unlisted_packages_page.html | 6 ++-- app/test/frontend/golden/search_page.html | 10 +++--- app/test/frontend/golden/topics_page.html | 6 ++-- .../testdata/goldens/packages/oxygen.html | 6 ++-- .../goldens/packages/oxygen/changelog.html | 6 ++-- .../goldens/packages/oxygen/example.html | 6 ++-- .../goldens/packages/oxygen/install.html | 6 ++-- .../goldens/packages/oxygen/license.html | 6 ++-- .../goldens/packages/oxygen/score.html | 16 +++++----- .../goldens/packages/oxygen/versions.html | 6 ++-- .../packages/oxygen/versions/1.0.0.html | 6 ++-- .../oxygen/versions/1.0.0/changelog.html | 6 ++-- .../oxygen/versions/1.0.0/example.html | 6 ++-- .../oxygen/versions/1.0.0/install.html | 6 ++-- .../oxygen/versions/1.0.0/license.html | 6 ++-- .../packages/oxygen/versions/1.0.0/score.html | 16 +++++----- .../packages/oxygen/versions/2.0.0.html | 6 ++-- .../lib/validation/html/html_validation.dart | 31 ++++++++++--------- 51 files changed, 178 insertions(+), 175 deletions(-) diff --git a/app/lib/frontend/dom/dom.dart b/app/lib/frontend/dom/dom.dart index 26b76f0cc6..0160beed23 100644 --- a/app/lib/frontend/dom/dom.dart +++ b/app/lib/frontend/dom/dom.dart @@ -448,6 +448,8 @@ class Image { Image({ required this.src, + + /// Note: the `alt` text of elements should not include the element type (e.g. `icon`). required this.alt, required this.width, required this.height, diff --git a/app/lib/frontend/templates/views/pkg/score_tab.dart b/app/lib/frontend/templates/views/pkg/score_tab.dart index 7e77e843c6..d912dbe7dc 100644 --- a/app/lib/frontend/templates/views/pkg/score_tab.dart +++ b/app/lib/frontend/templates/views/pkg/score_tab.dart @@ -140,7 +140,7 @@ d.Node _section(ReportSection section) { image: d.Image( src: staticUrls .getAssetUrl('/static/img/report-foldable-icon.svg'), - alt: 'icon to trigger folding of the section', + alt: 'trigger folding of the section', width: 13, height: 6, ), diff --git a/app/lib/frontend/templates/views/shared/search_banner.dart b/app/lib/frontend/templates/views/shared/search_banner.dart index f4ab45a640..b905738bfa 100644 --- a/app/lib/frontend/templates/views/shared/search_banner.dart +++ b/app/lib/frontend/templates/views/shared/search_banner.dart @@ -43,7 +43,7 @@ d.Node searchBannerNode({ image: d.Image( src: staticUrls .getAssetUrl('/static/img/search-filters-inactive.svg'), - alt: 'icon to toggle the display of search filters (inactive)', + alt: 'toggle the display of search filters (inactive)', width: 42, height: 42, ), @@ -53,7 +53,7 @@ d.Node searchBannerNode({ image: d.Image( src: staticUrls .getAssetUrl('/static/img/search-filters-active.svg'), - alt: 'icon to toggle the display of search filters (active)', + alt: 'toggle the display of search filters (active)', width: 42, height: 42, ), diff --git a/app/lib/frontend/templates/views/shared/site_header.dart b/app/lib/frontend/templates/views/shared/site_header.dart index df8742c38c..92ae2dcb14 100644 --- a/app/lib/frontend/templates/views/shared/site_header.dart +++ b/app/lib/frontend/templates/views/shared/site_header.dart @@ -237,7 +237,7 @@ d.Node _foldableMobileLinks(String label, Iterable children) { image: d.Image( src: staticUrls .getAssetUrl('/static/img/nav-mobile-foldable-icon.svg'), - alt: 'icon to toggle folding of the section', + alt: 'toggle folding of the section', width: 13, height: 6, ), diff --git a/app/test/frontend/golden/authorized_page.html b/app/test/frontend/golden/authorized_page.html index 31d9b45f4f..6e6fda48f6 100644 --- a/app/test/frontend/golden/authorized_page.html +++ b/app/test/frontend/golden/authorized_page.html @@ -74,7 +74,7 @@

Dart