Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[native_assets_cli] Disallow any other keys in the output file #94

Open
dcharkes opened this issue Jul 19, 2023 · 1 comment
Open

[native_assets_cli] Disallow any other keys in the output file #94

dcharkes opened this issue Jul 19, 2023 · 1 comment
Labels
P4 A feature or bug we're unlikely to address package:native_assets_cli

Comments

@dcharkes
Copy link
Collaborator

In a discussion with @jonasfj earlier, we discussed to disallow any other keys in the output file in order to ensure package authors implementing the protocol themselves don't prevent us from adding keys later.

Implementing this would mean that end users always need the newest Dart / Flutter SDK if the native_assets_cli used in their build.dart is new, otherwise it might output a key that is not yet accepted by the Dart / Flutter SDK. This might be an issue while we develop the package because we need to release new versions of native_assets_cli and native_assets_builder on pub before they can roll into flutter_tools (it doesn't use DEPS, but a normal pubspec.yaml). And it takes a couple of months for commits to reach Flutter and Dart stable.

Essentially, disallowing other keys in the output file makes adding keys to the output file a breaking change. I believe it's better to avoid causing breaking changes. So maybe it's better to not disallow other keys in the output file. wdyt @jonasfj

@dcharkes dcharkes added P4 A feature or bug we're unlikely to address package:native_assets_cli labels Jul 19, 2023
@jonasfj
Copy link
Member

jonasfj commented Jul 19, 2023

See comment #93 (comment)

@dcharkes dcharkes added this to the Native Assets v1.x milestone Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P4 A feature or bug we're unlikely to address package:native_assets_cli
Projects
Status: No status
Development

No branches or pull requests

2 participants