From a97011b4b031b1df94765dbacd7d92b0b765c8b9 Mon Sep 17 00:00:00 2001 From: Devon Carew Date: Wed, 25 Sep 2024 12:50:58 -0700 Subject: [PATCH] add unintended_html_in_doc_comment; rev to 5.1.0 (#211) * add unintended_html_in_doc_comment; rev to 5.1.0 * use 3.6 beta --- .github/workflows/publish.yaml | 2 ++ .github/workflows/validate.yml | 2 +- CHANGELOG.md | 8 ++++++++ lib/core.yaml | 1 + pubspec.yaml | 4 ++-- rules.md | 1 + tool/rules.json | 17 +++++++++++------ 7 files changed, 26 insertions(+), 9 deletions(-) diff --git a/.github/workflows/publish.yaml b/.github/workflows/publish.yaml index f416320..005c3ab 100644 --- a/.github/workflows/publish.yaml +++ b/.github/workflows/publish.yaml @@ -12,3 +12,5 @@ jobs: publish: if: ${{ github.repository_owner == 'dart-lang' }} uses: dart-lang/ecosystem/.github/workflows/publish.yaml@main + with: + sdk: beta diff --git a/.github/workflows/validate.yml b/.github/workflows/validate.yml index 3ae64df..3ad5316 100644 --- a/.github/workflows/validate.yml +++ b/.github/workflows/validate.yml @@ -17,7 +17,7 @@ jobs: strategy: fail-fast: false matrix: - sdk: [3.5, stable, beta] + sdk: [beta] # todo: re-add stable steps: - uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 diff --git a/CHANGELOG.md b/CHANGELOG.md index 9f1bd14..3012455 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,3 +1,11 @@ +## 5.1.0 + +- `core`: + - added [unintended_html_in_doc_comment] (https://github.com/dart-lang/lints/issues/192) +- Updated the SDK lower-bound to 3.6. + +[unintended_html_in_doc_comment]: https://dart.dev/lints/unintended_html_in_doc_comment + ## 5.0.0 - `recommended`: diff --git a/lib/core.yaml b/lib/core.yaml index 1cfe995..ca8a8ca 100644 --- a/lib/core.yaml +++ b/lib/core.yaml @@ -34,6 +34,7 @@ linter: - provide_deprecation_message - secure_pubspec_urls - type_literal_in_constant_pattern + - unintended_html_in_doc_comment - unnecessary_overrides - unrelated_type_equality_checks - use_string_in_part_of_directives diff --git a/pubspec.yaml b/pubspec.yaml index 3a45c87..3a0b6df 100644 --- a/pubspec.yaml +++ b/pubspec.yaml @@ -1,5 +1,5 @@ name: lints -version: 5.0.0 +version: 5.1.0 description: > Official Dart lint rules. Defines the 'core' and 'recommended' set of lints suggested by the Dart team. @@ -10,7 +10,7 @@ topics: - lints environment: - sdk: ^3.5.0 + sdk: ^3.6.0-0 # NOTE: Code is not allowed in this package - do not add dependencies. # dependencies: diff --git a/rules.md b/rules.md index 6aac54e..e4dd15e 100644 --- a/rules.md +++ b/rules.md @@ -33,6 +33,7 @@ | [`provide_deprecation_message`](https://dart.dev/lints/provide_deprecation_message) | Provide a deprecation message, via `@Deprecated("message")`. | | | [`secure_pubspec_urls`](https://dart.dev/lints/secure_pubspec_urls) | Use secure urls in `pubspec.yaml`. | | | [`type_literal_in_constant_pattern`](https://dart.dev/lints/type_literal_in_constant_pattern) | Don't use constant patterns with type literals. | ✅ | +| [`unintended_html_in_doc_comment`](https://dart.dev/lints/unintended_html_in_doc_comment) | Use of angle brackets in a doc comment is treated as HTML by Markdown. | | | [`unnecessary_overrides`](https://dart.dev/lints/unnecessary_overrides) | Don't override a method to do a super method invocation with the same parameters. | ✅ | | [`unrelated_type_equality_checks`](https://dart.dev/lints/unrelated_type_equality_checks) | Equality operator `==` invocation with references of unrelated types. | | | [`use_string_in_part_of_directives`](https://dart.dev/lints/use_string_in_part_of_directives) | Use string in part of directives. | ✅ | diff --git a/tool/rules.json b/tool/rules.json index 3fac4a2..d853c15 100644 --- a/tool/rules.json +++ b/tool/rules.json @@ -62,7 +62,7 @@ { "name": "avoid_catching_errors", "description": "Don't explicitly catch `Error` or types that implement it.", - "fixStatus": "unregistered" + "fixStatus": "noFix" }, { "name": "avoid_classes_with_only_static_members", @@ -432,7 +432,7 @@ { "name": "invalid_runtime_check_with_js_interop_types", "description": "Avoid runtime type tests with JS interop types where the result may not\n be platform-consistent.", - "fixStatus": "needsFix" + "fixStatus": "needsEvaluation" }, { "name": "invariant_booleans", @@ -531,7 +531,7 @@ }, { "name": "no_literal_bool_comparisons", - "description": "Don't compare Boolean expressions to Boolean literals.", + "description": "Don't compare boolean expressions to boolean literals.", "fixStatus": "hasFix" }, { @@ -884,6 +884,11 @@ "description": "Sort unnamed constructor declarations first.", "fixStatus": "hasFix" }, + { + "name": "specify_nonobvious_local_variable_types", + "description": "Specify non-obvious type annotations for local variables.", + "fixStatus": "hasFix" + }, { "name": "super_goes_last", "description": "Place the `super` call last in a constructor initialization list.", @@ -1062,17 +1067,17 @@ { "name": "unrelated_type_equality_checks", "description": "Equality operator `==` invocation with references of unrelated types.", - "fixStatus": "unregistered" + "fixStatus": "needsEvaluation" }, { "name": "unsafe_html", "description": "Avoid unsafe HTML APIs.", - "fixStatus": "unregistered" + "fixStatus": "noFix" }, { "name": "use_build_context_synchronously", "description": "Do not use `BuildContext` across asynchronous gaps.", - "fixStatus": "unregistered" + "fixStatus": "noFix" }, { "name": "use_colored_box",