Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CupertinoClient close method doesn't close the connection #1131

Closed
veloce opened this issue Feb 14, 2024 · 1 comment · Fixed by #1191
Closed

CupertinoClient close method doesn't close the connection #1131

veloce opened this issue Feb 14, 2024 · 1 comment · Fixed by #1191
Assignees
Labels
package:cupertino_http Issues related to package:cupertino_http type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)

Comments

@veloce
Copy link

veloce commented Feb 14, 2024

CupertinoClient doesn't close the underlying connection when calling close() on it. It will just prevent sending further requests.

It is an issue because a persistent connection won't be closed, and we have no way to cancel a pending request.

Also it is not consistent with the behaviour of IOClient, which does close the connection.

@veloce veloce added package:cupertino_http Issues related to package:cupertino_http type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) labels Feb 14, 2024
@brianquinlan
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:cupertino_http Issues related to package:cupertino_http type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants