Fix dependency on discontinued js package

[kirkmorrow]

The package js, which build_runner has a dependency on, was marked discontinued with release 0.7.2 on Feb. 12, 2025. The recommendation is to use js_interop instead moving forward per https://pub.dev/packages/js.

[jakemac53]

This should have been completed in #3793

[lishaduck]

@jakemac53, that removed actual usage of js, but it's still listed as a dependency:

build/build_runner/pubspec.yaml

Line 34 in 7dbcd85

js: '>=0.6.3 <0.8.0'

---

And it looks like build_web_compilers still depends on it as well.

[jakemac53]

Weird, I didn't see any more diagnostics, but yeah any remaining usage should be removed

[jakemac53]

Oh you are saying it's an unused dependency that just didn't get cleaned up

[lishaduck]

Oh you are saying it's an unused dependency that just didn't get cleaned up

In build_runner, yes, in build_web_compilers, there's an actual use (but there's an ignore_deprecated_member_use, so that's probably why you didn't see diagnostics)

[lishaduck]

Here's build_web_compilers:

build/build_web_compilers/web/stack_trace_mapper.dart

Lines 27 to 28 in 7dbcd85

	// ignore: deprecated_member_use
	import 'package:js/js.dart';

[jakemac53]

ohhh, we just ignored it 🤕

[davidmorgan]

Yes, I added the ignore as it broke CI :)

I guess it's okay if I get to this in a week or two, nothing's on fire?

[lishaduck]

I don't depend on build_web_compilers, but can we at least remove the unused dependency on js in build_runner on Monday?

(It's not breaking me, it's just that it's a tiny, separate patch that I'm sure others will hit pretty soon. Enjoy your weekend!)

[davidmorgan]

They'll just see a warning, I think? Or is there actual breakage?

[lishaduck]

They'll just see a warning, I think? Or is there actual breakage?

Just a warning, but again, it's a one-line fix and I'm certain some people will read "deprecated" and freak out (see: npm ecosystem).

[davidmorgan]

I'm in the middle of a huge refactoring, it's not straightforward to do a release right now. Hopefully this week.