Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support build segwit transaction #26

Closed
SFzxc opened this issue Jan 23, 2020 · 10 comments
Closed

Support build segwit transaction #26

SFzxc opened this issue Jan 23, 2020 · 10 comments

Comments

@SFzxc
Copy link
Collaborator

SFzxc commented Jan 23, 2020

@SFzxc
Copy link
Collaborator Author

SFzxc commented Jan 23, 2020

Lunar new year now, Will come back soon

@RohanKapurDEV
Copy link
Contributor

RohanKapurDEV commented Feb 16, 2020

Hey guys, any progress here?

Edit: is this package still being developed on?

@RohanKapurDEV
Copy link
Contributor

Hey I understand you may be busy. How can I help develop the Native Segwit Transaction Builder?

Specifically:

  1. How much is already done?
  2. What is left to port over from BitcoinJS?

If someone writes a detailed answer outlining exactly the parts i need to port over, i will try to help as much as possible but I'm not sure how much has been done since there is no documentation. Give me the way forward and I'll try my best.

@SFzxc
Copy link
Collaborator Author

SFzxc commented Mar 3, 2020

@RohanKapurDEV Sorry, i'm so busy now, i added test to cover segwit tx cases. you just need to write code to pass all testcases.
Run pub run test to see which testcase is failed

@RohanKapurDEV
Copy link
Contributor

I have been reviewing the files. Finding this rather difficult honestly. What do you think about me trying to integrate PSBT for bitcoin-flutter, seems a bit more future proof anyway, no?

@SFzxc
Copy link
Collaborator Author

SFzxc commented Mar 3, 2020

@RohanKapurDEV Sure, PSBT must have soon, appreciate it!

@RohanKapurDEV
Copy link
Contributor

So I've started the skeleton of the PSBT in dart. I'm going to attempt to port over the BIP174 library from Alex Bosworth here: https://github.com/alexbosworth/psbt.

However, since this will likely take me a while (a few months at the least), do you think you could continue to work on the segwit support for the transactionbuilder since you've already started. We may end up with a more robust library if we have both.

Thanks, let me know.

@longhoangwkm
Copy link
Collaborator

i will, but quite slow

@longhoangwkm
Copy link
Collaborator

@longhoangwkm
Copy link
Collaborator

Moved to here #27

@SFzxc SFzxc closed this as completed Mar 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants