Skip to content
This repository has been archived by the owner on Feb 22, 2018. It is now read-only.

implement case labels #263

Closed
jmesserly opened this issue Jul 22, 2015 · 2 comments
Closed

implement case labels #263

jmesserly opened this issue Jul 22, 2015 · 2 comments
Labels
area-dev-compiler

Comments

@jmesserly
Copy link
Contributor

https://github.com/dart-lang/dev_compiler/blob/1c029d0902387059b16866c0c41489e7739ea89a/lib/src/codegen/js_codegen.dart#L2512

rarely used outside tests, but async tests trip on this, so hit while looking at #221. I doubt we need a readable solution, rather just a legal translation or some sort.
@jmesserly jmesserly assigned jmesserly and unassigned jmesserly Jul 22, 2015
@jmesserly
Copy link
Contributor Author

for now I just commented out those tests.
maybe an intermediate fix would be to not generate invalid code :) ... right now we skip the case label, but we generate continue label; which makes JS parser unhappy.

@jmesserly jmesserly mentioned this issue Apr 14, 2017
Closed
@jmesserly
Copy link
Contributor Author

This issue was moved to dart-lang/sdk#29352

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area-dev-compiler
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jmesserly