Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unsubscribe() successful, but the callback unsubscribed_info.was_error is true #16

Closed
petten opened this issue Nov 11, 2017 · 5 comments

Comments

@petten
Copy link

petten commented Nov 11, 2017

I moved up to release 1.5, although had to change all the callbacks. That came to pass, and all seems well except this:

When calling unsubscribe(), the lockable logger I passed to wampcc was able to log:

LOG 20171110-19:22:53.081567 14684 INFO unsubscribed, subscription_id 28, request_id 3 ...

But upon examining the callback arg struct unsubscribed_info, I found its was_error member was set to true.

I'm sure the previous wampcc version that I had used for a long time had its was_error member set to the right value, though the struct had a different name.

@darrenjs
Copy link
Owner

Yep ... I'm able to reproduce. Seems like bug. Will fix soon.

@darrenjs
Copy link
Owner

fixed on master branch, commit fcb79e5

@petten
Copy link
Author

petten commented Nov 14, 2017

Another minor thing - my compiler (GCC 5.4) made a little noise about this:

... include/wampcc/wamp_session.h:94:28: warning: missing initializer for member 'wampcc::auth_provider::user_secret' [-Wmissing-field-initializers] nullptr, nullptr };

It can be made to go away by one's adding one more , nullptr before }; at the end.

@petten
Copy link
Author

petten commented Nov 14, 2017

Fix confirmed

@darrenjs
Copy link
Owner

added your suggestion to resolve compiler warning.

@petten petten closed this as completed Nov 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants