From 564c3c3539b2026bfeb3964175274ae366f0542d Mon Sep 17 00:00:00 2001
From: Paul Aurich <paul@darkrain42.org>
Date: Wed, 3 May 2023 19:43:14 -0700
Subject: [PATCH 1/2] Create /etc/resolv.conf in initramfs for tailscale client

On Debian systems, unless configured by something else, there isn't an
/etc/resolv.conf in the initramfs, which hinders DNS resolution.
Tailscale has its fallback DNS functionality, but that has problems [1]
in the corner-case situation of a Debian initramfs environment:

- no /etc/resolv.conf means tailscale (or golang?) attempts to use
  127.0.0.1 as a DNS resolver
- the loopback interface (lo) isn't brought up in the initramfs. linux
  sends the DNS traffic off-device (destined for 127.0.0.1)

Even with the Tailscale fix for that issue, it's a fallback and there's
a noticeable delay, so do the correct thing here and create
/etc/resolv.conf.

[1] https://github.com/tailscale/tailscale/issues/6110
---
 config/config                   | 12 ++++++++++++
 debian/changelog                |  7 +++++++
 scripts/init-premount/tailscale | 33 ++++++++++++++++++++++++++++++++-
 3 files changed, 51 insertions(+), 1 deletion(-)

diff --git a/config/config b/config/config
index 90266b1..48dba5f 100644
--- a/config/config
+++ b/config/config
@@ -43,6 +43,18 @@ TAILSCALE_AUTHKEY=
 #
 #TAILSCALE_LOGOUT=
 
+#
+# Space-delimited list of DNS server(s) to put in /etc/resolv.conf in the
+# initramfs if /etc/resolv.conf doesn't exist and if no DNS servers were
+# returned from DHCP.
+#
+# Tailscale will eventually fall back to bootstrapping DNS itself, but there's
+# no reason to rely on that (adds a slight delay).  Tailscale's fallback is
+# also problematic in some corner cases in some versions (see
+# https://github.com/tailscale/tailscale/issues/6110).
+#
+#FALLBACK_DNS_SERVERS=
+
 #
 # Bring down interfaces matching this pattern before passing out of the
 # initramfs.  (Same behavior as dropbear-initramfs)
diff --git a/debian/changelog b/debian/changelog
index 8d0b204..e9fb142 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,10 @@
+tailscale-initramfs (0.3) unstable; urgency=medium
+
+  * Configure resolv.conf in initramfs if it isn't already, so the tailscale
+    client can reach the control server more reliably.
+
+ -- Paul Aurich <paul@darkrain42.org>  Wed, 03 May 2023 19:52:49 -0700
+
 tailscale-initramfs (0.2) unstable; urgency=medium
 
   * Keep trying to bring up the network until it either comes up or the boot
diff --git a/scripts/init-premount/tailscale b/scripts/init-premount/tailscale
index ed36d79..55d93fc 100755
--- a/scripts/init-premount/tailscale
+++ b/scripts/init-premount/tailscale
@@ -39,12 +39,39 @@ network_up()
 {
     for conf in /run/net-*.conf /run/net6-*.conf; do
         if [ -e "$conf" ]; then
+            # shellcheck disable=SC1090
+            . "$conf"
             return 0
         fi
     done
     return 1
 }
 
+# shellcheck disable=SC3043
+create_resolv_conf()
+{
+    if [ -e /etc/resolv.conf ]; then
+        return
+    fi
+
+    local ns
+    for ns in "${IPV4DNS0:-}" "${IPV4DNS1:-}" "${IPV6DNS0:-}" "${IPV6DNS1:-}"; do
+        if [ -n "$ns" ] && [ "$ns" != "0.0.0.0" ]; then
+            echo "nameserver $ns" >> /etc/resolv.conf
+        fi
+    done
+
+    if [ -e /etc/resolv.conf ]; then
+        return
+    fi
+
+    for ns in ${FALLBACK_DNS_SERVERS:-}; do
+        if [ -n "$ns" ]; then
+            echo "nameserver $ns" >> /etc/resolv.conf
+        fi
+    done
+}
+
 # shellcheck disable=SC2039,SC2086,SC3043
 run_tailscale()
 {
@@ -62,7 +89,11 @@ run_tailscale()
             # in a subshell and wait for it.
             configure_networking &
             wait $!
-            if ! [ -e "$PIDFILE" ] || network_up; then
+            if ! [ -e "$PIDFILE" ]; then
+                break
+            fi
+            if network_up; then
+                create_resolv_conf
                 break
             fi
         done

From 6945048f3958da5e469aab3800c26152a6919af0 Mon Sep 17 00:00:00 2001
From: Paul Aurich <paul@darkrain42.org>
Date: Wed, 3 May 2023 19:59:43 -0700
Subject: [PATCH 2/2] workflows: bump shellcheck version

---
 .github/workflows/build.yml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
index a91e84f..2dc490c 100644
--- a/.github/workflows/build.yml
+++ b/.github/workflows/build.yml
@@ -17,7 +17,7 @@ jobs:
       - uses: actions/checkout@v3
 
       - name: ShellCheck
-        uses: ludeeus/action-shellcheck@1.1.0
+        uses: ludeeus/action-shellcheck@2.0.0
         env:
           SHELLCHECK_OPTS: -e SC1091