Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ReviewViewer] Struggling to compile source code #597

Open
jeanphilt opened this issue Dec 17, 2024 · 2 comments
Open

[ReviewViewer] Struggling to compile source code #597

jeanphilt opened this issue Dec 17, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@jeanphilt
Copy link

Extension name

ReviewViewer

Bug Description

Hi Brandon,

I'm a software developer so I'm usually pretty good at this stuff but I struggle to get it to compile with VS 2022 and PlayniteExtensions.sln.
I tried to download the latest release but there are a lot of errors like this line is missing the second parameter at the end.
var downloadOptions = new VideoDownloadOptions(VideoType.Trailer,);
Aside from that, there are a lot of mising assemblies.
I tried to fix some with nuget but I'm starting to wonder, should I be using an older release or am I missing something ?

On the plus side, I was able to compile ReviewViewer by loading the .sln of that solution.

Thank you,
Jp

To Reproduce

No response

Logs

.

Screenshots

No response

@jeanphilt jeanphilt added the bug Something isn't working label Dec 17, 2024
@jeanphilt
Copy link
Author

FYI, I came up with a few ideas, still working on it :
https://www.reddit.com/r/playnite/comments/1bi86xm/comment/m24sdj3/?context=3

@darklinkpower
Copy link
Owner

I'm a little confused, are the compilation issues for ReviewsViewer or another extension? Because var downloadOptions = new VideoDownloadOptions(VideoType.Trailer,); should be part of Extra Metadata Loader if I'm correct. If that's the case, currently it won't compile because I'm rewriting and refactoring the extension and it's unfinished. To compile it you'll need to use a commit before this one:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants