-
-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update types.ts to allow more cookies group #217
Conversation
Update types to allow more cookies group
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As mentioned, I'd like these categories to be customizable by the user, keeping the default to the current behavior. So hardcoding arbitrary values won't be an option here, I'm afraid.
Custom cookie control
i generate new commits with full user customization cookies group, avoid types |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This changeset still breaks functionality, e.g. when trying to open the modal: Also, it doesn't seem to have gotten the backwards compatibility added back in and the linter shows some errors: I'll close this PR now, as I don't see enough progress towards non-breaking changes. Please only continue contributions that satisfy change requests or the build tooling. |
Update types to allow more cookies group
📚 Description
Fix #216
📝 Checklist