Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update types.ts to allow more cookies group #217

Closed
wants to merge 4 commits into from

Conversation

agracia-foticos
Copy link

Update types to allow more cookies group

📚 Description

Fix #216

📝 Checklist

  • feat(component): add new types

Update types to allow more cookies group
Copy link
Owner

@dargmuesli dargmuesli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As mentioned, I'd like these categories to be customizable by the user, keeping the default to the current behavior. So hardcoding arbitrary values won't be an option here, I'm afraid.

@agracia-foticos
Copy link
Author

i generate new commits with full user customization cookies group, avoid types

Copy link
Owner

@dargmuesli dargmuesli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think those changes do not keep the current behavior as default. Also the project stops working with the current changeset:
image
Maybe try running the playground, the linter and the build to make sure the changes you propose are not breaking.

@agracia-foticos
Copy link
Author

I think those changes do not keep the current behavior as default. Also the project stops working with the current changeset: image Maybe try running the playground, the linter and the build to make sure the changes you propose are not breaking.

I feel the inconvenience, here you are a new version. i wait for your notices

@dargmuesli
Copy link
Owner

This changeset still breaks functionality, e.g. when trying to open the modal:

image

Also, it doesn't seem to have gotten the backwards compatibility added back in and the linter shows some errors:

image

I'll close this PR now, as I don't see enough progress towards non-breaking changes. Please only continue contributions that satisfy change requests or the build tooling.

@dargmuesli dargmuesli closed this Jun 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: customizable cookie groups
2 participants