Incremental source generator for actors #1334

m3nax · 2024-08-02T07:29:54Z

Description

Converted the Actor source generator into an IncrementalSourceGenerator to ease the future definition of new generation pipeline for other objects (E.g: #1305 (comment))

It also add a null check for actorProxy parameter passed in generated Actor ctor, definition of AnalyzerReleases.Shipped.md and AnalyzerReleases.Unshipped.md diagnostics, remove deprecated nugets.

Issue reference

_

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

Code compiles correctly
Created/updated tests
Extended the documentation

all.sln

src/Dapr.Actors.Generators/ActorClientGenerator.cs

src/Dapr.Actors.Generators/Extensions/IEnumerableExtensions.cs

* up Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com> * Fixed build Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com> * Added scripts for image build Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com> * Added readme Build and push Docker image Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com> * Added demo-actor.yaml Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com> * Fixed typo Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com> * Updated guide, fixed invocation throw curl Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com> * Removed dockerfile, updated readme, removed ps1 and sh scripts Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com> * Updated base image Signed-off-by: Manuel Menegazzo <65919883+m3nax@users.noreply.github.com> Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com> * Update demo-actor.yaml Signed-off-by: Manuel Menegazzo <65919883+m3nax@users.noreply.github.com> Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com> * Added overload for DaprClient DI registration (dapr#1289) * Added overload for DaprClient DI registration allowing the consumer to easily use values from injected services (e.g. IConfiguration). Signed-off-by: Whit Waldo <whit.waldo@innovian.net> * Added supporting unit test Signed-off-by: Whit Waldo <whit.waldo@innovian.net> --------- Signed-off-by: Whit Waldo <whit.waldo@innovian.net> Co-authored-by: Phillip Hoff <phillip@orst.edu> Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com> * Merge `release-1.13` back into `master` (dapr#1285) * Update protos and related use for Dapr 1.13. (dapr#1236) * Update protos and related use. Signed-off-by: Phillip Hoff <phillip@orst.edu> * Update Dapr runtime version. Signed-off-by: Phillip Hoff <phillip@orst.edu> * Init properties. Signed-off-by: Phillip Hoff <phillip@orst.edu> --------- Signed-off-by: Phillip Hoff <phillip@orst.edu> * Update artifact action versions. (dapr#1240) Signed-off-by: Phillip Hoff <phillip@orst.edu> * Make recursive true as default (dapr#1243) Signed-off-by: Shivam Kumar <shivamkm07@gmail.com> * Fix for secret key transformation in multi-value scenarios (dapr#1274) * Add repro test. Signed-off-by: Phillip Hoff <phillip@orst.edu> * Fix for secret key transformation in multi-value scenarios. Signed-off-by: Phillip Hoff <phillip@orst.edu> --------- Signed-off-by: Phillip Hoff <phillip@orst.edu> * Update Dapr version numbers used during testing. Signed-off-by: Phillip Hoff <phillip@orst.edu> --------- Signed-off-by: Phillip Hoff <phillip@orst.edu> Signed-off-by: Shivam Kumar <shivamkm07@gmail.com> Co-authored-by: Shivam Kumar <shivamkm07@gmail.com> Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com> --------- Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com> Signed-off-by: Manuel Menegazzo <65919883+m3nax@users.noreply.github.com> Signed-off-by: Whit Waldo <whit.waldo@innovian.net> Signed-off-by: Phillip Hoff <phillip@orst.edu> Signed-off-by: Shivam Kumar <shivamkm07@gmail.com> Co-authored-by: Whit Waldo <whit.waldo@innovian.net> Co-authored-by: Phillip Hoff <phillip@orst.edu> Co-authored-by: Shivam Kumar <shivamkm07@gmail.com> Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com>

Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com>

…apr#1277) * Handled creation of ActorReference from Actor base class Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com> * Updated null check Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com> * Added unit test for GetActorReference from null actore and actor proxy Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com> * Added test for ActorReference created inside Actor implementation Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com> * Updated description Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com> * Fixed test method naming Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com> * Added unit test for exception generated in case the type is not convertible to an ActorReference Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com> --------- Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com>

Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com>

Signed-off-by: Hannah Hunter <hannahhunter@microsoft.com> Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com>

Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com>

Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com> Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com>

Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com>

codecov · 2024-09-04T19:45:44Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.68%. Comparing base (1b7c9f4) to head (6b219d2).
Report is 18 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1334      +/-   ##
==========================================
+ Coverage   67.28%   67.68%   +0.39%     
==========================================
  Files         174      175       +1     
  Lines        6025     6059      +34     
  Branches      671      675       +4     
==========================================
+ Hits         4054     4101      +47     
+ Misses       1802     1788      -14     
- Partials      169      170       +1

Flag	Coverage Δ
net6	`?`
net7	`?`
net8	`67.68% <ø> (+0.41%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

m3nax · 2024-09-04T20:04:32Z

@KrylixZA really thank for taking time to review my pr.

src/Dapr.Actors.Generators/ActorClientGenerator.cs

src/Dapr.Actors.Generators/Templates.cs

KrylixZA

My knowledge of source generators is limited. I joined the review more to learn than anything else. Thanks for the education! 😉

That said, LGTM. We'll still need one of the Dapr maintainers to approve before it merges though as I am not on that list yet.

Thanks for your contributing!

Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com>

m3nax force-pushed the incremental-source-generator-for-actors branch from 21683a6 to a3a3e68 Compare August 9, 2024 17:03

m3nax marked this pull request as ready for review August 9, 2024 17:12

m3nax requested review from a team as code owners August 9, 2024 17:12

m3nax closed this Aug 9, 2024

m3nax reopened this Aug 9, 2024

KrylixZA reviewed Aug 29, 2024

View reviewed changes

all.sln Outdated Show resolved Hide resolved

KrylixZA reviewed Sep 2, 2024

View reviewed changes

src/Dapr.Actors.Generators/ActorClientGenerator.cs Outdated Show resolved Hide resolved

KrylixZA reviewed Sep 3, 2024

View reviewed changes

src/Dapr.Actors.Generators/Extensions/IEnumerableExtensions.cs Outdated Show resolved Hide resolved

WhitWaldo mentioned this pull request Sep 3, 2024

Removed deprecated Workflow methods and types from DaprClient and tests #1345

Open

3 tasks

m3nax force-pushed the incremental-source-generator-for-actors branch from ea7d9ba to 53964b4 Compare September 3, 2024 18:51

m3nax and others added 19 commits September 4, 2024 20:10

Aligned nuget version

7711fd6

Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com>

UP

30189be

Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com>

UP

86c881a

Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com>

Debug profile added

c44384b

Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com>

Updated implementation

9f9a4b7

Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com>

Emitted DAPR001 Diagnostic warning

c86c709

Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com>

Added DAPR002 diagnostic

38f4fc1

Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com>

Cleaun

8611f67

Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com>

UP

56b9ab9

Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com>

Added summaries

a2f3616

Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com>

Added base interface to ActorClient

b2deca7

Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com>

Updated

45ef4f6

Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com>

Added ctor

a756015

Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com>

Added nullable directive

28db658

Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com>

Added null check for actorproxy ctor parameter

4be5bb7

Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com>

Moved DiagnoticException in a dedicate cs file

c24d310

Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com>

Moved generator costants to dedicated class

28fc7fe

Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com>

m3nax and others added 16 commits September 4, 2024 20:10

Simplified proxy argument definition

cf34718

Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com>

Explicit generic arguments of the proxy call during generation

493cbec

Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com>

Handled cancellation token with default value

0c287f1

Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com>

Fixed typo

ad2c22d

Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com>

Configured eol used in NormalizeWhitespace function

4d336c8

Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com>

Normalized expected source

3bc0674

Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com>

Moved to constat the ActorProxyTypeName

c0f9c47

Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com>

Fix typo

7a86b4f

Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com>

Created ActorProxyInvokeMethodAsync SyntaxFactoryHelper

c5f5f11

Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com>

Removed custom concat implementation

51ed60d

Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com>

fix (dapr#1329)

f8b3199

Signed-off-by: Hannah Hunter <hannahhunter@microsoft.com> Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com>

link to non-dapr endpoint howto (dapr#1335)

acfbfe7

Signed-off-by: Hannah Hunter <hannahhunter@microsoft.com> Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com>

Merge 1.14 release branch back into master. (dapr#1337)

2d4fe2f

Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com>

Fixed merge errors

a033218

Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com> Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com>

Updated some summaries

494383c

Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com>

Added some missing summaries

89b4069

Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com>

m3nax force-pushed the incremental-source-generator-for-actors branch from e176e63 to 89b4069 Compare September 4, 2024 18:10

m3nax added 4 commits September 4, 2024 20:53

Fixed typo

39b4289

Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com>

Merged

66bf943

Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com>

Improved some summary text

30bb460

Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com>

Improved summaries

6b219d2

Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com>

m3nax requested a review from KrylixZA September 4, 2024 19:46

KrylixZA reviewed Sep 6, 2024

View reviewed changes

src/Dapr.Actors.Generators/ActorClientGenerator.cs Outdated Show resolved Hide resolved

KrylixZA reviewed Sep 6, 2024

View reviewed changes

src/Dapr.Actors.Generators/Templates.cs Outdated Show resolved Hide resolved

KrylixZA approved these changes Sep 6, 2024

View reviewed changes

Handled review requests

4e99586

Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com>

m3nax closed this Sep 10, 2024

m3nax reopened this Sep 10, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Incremental source generator for actors #1334

Incremental source generator for actors #1334

m3nax commented Aug 2, 2024 •

edited

Loading

codecov bot commented Sep 4, 2024

m3nax commented Sep 4, 2024

KrylixZA left a comment

Incremental source generator for actors #1334

Are you sure you want to change the base?

Incremental source generator for actors #1334

Conversation

m3nax commented Aug 2, 2024 • edited Loading

Description

Issue reference

Checklist

codecov bot commented Sep 4, 2024

Codecov Report

m3nax commented Sep 4, 2024

KrylixZA left a comment

Choose a reason for hiding this comment

m3nax commented Aug 2, 2024 •

edited

Loading