-
Notifications
You must be signed in to change notification settings - Fork 334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added .NET client for new Dapr Jobs API support #1320
Conversation
Signed-off-by: Whit Waldo <whit.waldo@innovian.net>
/assign |
Signed-off-by: Whit Waldo <whit.waldo@innovian.net>
Signed-off-by: Whit Waldo <whitwaldo@innovian.net>
…endencies in both Dapr.Client and Dapr.AspNetCore Signed-off-by: Whit Waldo <whit.waldo@innovian.net>
Signed-off-by: Whit Waldo <whit.waldo@innovian.net>
Signed-off-by: Whit Waldo <whit.waldo@innovian.net>
…riate gRPC types + client Signed-off-by: Whit Waldo <whit.waldo@innovian.net>
Signed-off-by: Whit Waldo <whit.waldo@innovian.net>
Signed-off-by: Whit Waldo <whit.waldo@innovian.net>
… Jobs Signed-off-by: Whit Waldo <whit.waldo@innovian.net>
…namespace the job is being requested by Signed-off-by: Whit Waldo <whit.waldo@innovian.net>
Signed-off-by: Whit Waldo <whit.waldo@innovian.net>
…ace so nothing is changed in Dapr.Client Signed-off-by: Whit Waldo <whit.waldo@innovian.net>
Signed-off-by: Whit Waldo <whit.waldo@innovian.net>
Signed-off-by: Whit Waldo <whit.waldo@innovian.net>
Signed-off-by: Whit Waldo <whit.waldo@innovian.net>
Oh good, all the tests are passing again. Glad to see that! I'll see if I can't hammer out some unit tests to go with and get this to run locally so I can trial out that sample project too and get this wrapped up. |
…apr" Signed-off-by: Whit Waldo <whit.waldo@innovian.net>
Signed-off-by: Whit Waldo <whit.waldo@innovian.net>
Signed-off-by: Whit Waldo <whit.waldo@innovian.net>
Signed-off-by: Whit Waldo <whit.waldo@innovian.net>
…e project Signed-off-by: Whit Waldo <whit.waldo@innovian.net>
Signed-off-by: Whit Waldo <whit.waldo@innovian.net>
Signed-off-by: Whit Waldo <whit.waldo@innovian.net>
Signed-off-by: Whit Waldo <whit.waldo@innovian.net>
…ck in GRPC client implementation to check for negative values. Signed-off-by: Whit Waldo <whit.waldo@innovian.net>
Signed-off-by: Whit Waldo <whit.waldo@innovian.net>
… instead of creating a new instance from the DaprClientGenericBuilder. Signed-off-by: Whit Waldo <whit.waldo@innovian.net>
…nt - caught while augmenting unit tests Signed-off-by: Whit Waldo <whit.waldo@innovian.net>
Signed-off-by: Whit Waldo <whit.waldo@innovian.net>
Signed-off-by: Whit Waldo <whit.waldo@innovian.net>
…compatible objects. Signed-off-by: Whit Waldo <whit.waldo@innovian.net>
…dule method to the next Signed-off-by: Whit Waldo <whit.waldo@innovian.net>
… used anywhere. Rather, previous commits provided helper extensions that will allow configurable serialization, but the methods exposed on the DaprJobsClient assume the developer will bring their own serialization approach to bear. Signed-off-by: Whit Waldo <whit.waldo@innovian.net>
Signed-off-by: Whit Waldo <whit.waldo@innovian.net>
…cy on Dapr.Client. Signed-off-by: Whit Waldo <whit.waldo@innovian.net>
…references through project references. This is unfortunate because it requires some updates for nullability changes which was hopefully out of scope for this initative. Signed-off-by: Whit Waldo <whit.waldo@innovian.net>
….Extensions.Http 8.0.0 by rolling that version back to 3.1.32 (updated Dapr.Extensions.Configuration to the latest minor release of 3.1.32 from 3.1.2 in the process). Signed-off-by: Whit Waldo <whit.waldo@innovian.net>
@philliphoff In the latest batch of commits, I added a collection of extension methods that'll support JSON and string serialization (with a As I discovered after a few failing unit tests, Moq doesn't work with static methods, which makes this project rather difficult to get full coverage on. Is there any interest at some point in seeing if there's a commercial mocking framework that would grant a license for this open-source project (e.g. Telerik's JustMock)? I've got to imagine there are a great many opportunities for richer coverage we just can't test with open-source mocking tooling. Finally, I added a change to the generic Dapr client builder that took a dependency on |
…PI token Signed-off-by: Whit Waldo <whit.waldo@innovian.net>
Unclear why the build is failing on CI/CD - it's building all the way through locally. |
Signed-off-by: Whit Waldo <whit.waldo@innovian.net>
@philliphoff Closing this PR in favor of #1331 now that all the unit tests are passing. Did a squash merge per your suggestion to fix the DCO error. |
Description
Added a Dapr Jobs client for the new Jobs API
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #1321
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list:
This isn't yet ready to be merged as I need to figure out how the sidecar signals job triggers back to the app.