Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding instance-based CreateInvokableHttpClient #1319

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Adding instance-based CreateInvokableHttpClient #1319

wants to merge 6 commits into from

Commits on Jul 4, 2024

  1. Added override to DaprClient that produces an invokable HttpClient mu… 

    …ch like the static method, but using the DaprApiToken already persisted (meaning this can be created from the injected DaprClient instance)

Signed-off-by: Whit Waldo <whit.waldo@innovian.net>
    @WhitWaldo
    WhitWaldo committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    14f11f8 View commit details
    Browse the repository at this point in the history

  2. Adds unit tests for implementation mirroring functionality of existin… 

    …g unit tests for static method

Signed-off-by: Whit Waldo <whit.waldo@innovian.net>
    @WhitWaldo
    WhitWaldo committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    45c8c6e View commit details
    Browse the repository at this point in the history

  3. Removed DaprEndpoint property as it should utilize that registered wi… 

    …th the DaprClient instance. If a developer wants to opt-out, they should use the static invocation method instead.

Updated unit tests to exclude invalid endpoints as that's handled by the DaprClient instead now.

Signed-off-by: Whit Waldo <whit.waldo@innovian.net>
    @WhitWaldo
    WhitWaldo committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    14c2172 View commit details
    Browse the repository at this point in the history

Commits on Sep 3, 2024

  1. Merge branch 'master' into invokable-httpclient-from-client

    @WhitWaldo
    WhitWaldo committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    1ea569b View commit details
    Browse the repository at this point in the history

  2. Removed nullability annotation as it's not supposed to be there for t… 

    …his PR

Signed-off-by: Whit Waldo <whit.waldo@innovian.net>
    @WhitWaldo
    WhitWaldo committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    eee54c7 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'invokable-httpclient-from-client' of https://github.com… 

    …/WhitWaldo/dapr-dotnet-sdk into invokable-httpclient-from-client
    @WhitWaldo
    WhitWaldo committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    3be6e3b View commit details
    Browse the repository at this point in the history