-
Notifications
You must be signed in to change notification settings - Fork 334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added ActorReference creation from the ActorBase class informations #1277
Added ActorReference creation from the ActorBase class informations #1277
Conversation
b37f235
to
c68209e
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1277 +/- ##
==========================================
+ Coverage 67.28% 67.55% +0.26%
==========================================
Files 174 174
Lines 6025 6041 +16
Branches 671 671
==========================================
+ Hits 4054 4081 +27
+ Misses 1802 1790 -12
- Partials 169 170 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
40067d4
to
a03a213
Compare
Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com>
Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com>
Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com>
Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com>
Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com>
Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com>
…rtible to an ActorReference Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com>
a03a213
to
98497a7
Compare
@philliphoff Another transient error seems to have appeared in actions. Is there a command that can be given to re-execute actions? Recorded error in
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, @m3nax. Just need to resolve the merge conflict and it can be committed.
@philliphoff Done |
@philliphoff can be included in v1.14 milestone? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…apr#1277) * Handled creation of ActorReference from Actor base class Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com> * Updated null check Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com> * Added unit test for GetActorReference from null actore and actor proxy Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com> * Added test for ActorReference created inside Actor implementation Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com> * Updated description Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com> * Fixed test method naming Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com> * Added unit test for exception generated in case the type is not convertible to an ActorReference Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com> --------- Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com>
…apr#1277) * Handled creation of ActorReference from Actor base class Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com> * Updated null check Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com> * Added unit test for GetActorReference from null actore and actor proxy Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com> * Added test for ActorReference created inside Actor implementation Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com> * Updated description Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com> * Fixed test method naming Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com> * Added unit test for exception generated in case the type is not convertible to an ActorReference Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com> --------- Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com>
…apr#1277) * Handled creation of ActorReference from Actor base class Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com> * Updated null check Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com> * Added unit test for GetActorReference from null actore and actor proxy Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com> * Added test for ActorReference created inside Actor implementation Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com> * Updated description Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com> * Fixed test method naming Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com> * Added unit test for exception generated in case the type is not convertible to an ActorReference Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com> --------- Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com>
Description
// TODO check for ActorBase
in the code of ActorReference class.Example:
Issue reference
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: