-
Notifications
You must be signed in to change notification settings - Fork 334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding in new test for parallel raise events in workflow #1155
Conversation
Signed-off-by: Ryan Lettieri <ryanLettieri@microsoft.com>
Signed-off-by: Ryan Lettieri <ryanLettieri@microsoft.com>
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1155 +/- ##
=======================================
Coverage 66.42% 66.42%
=======================================
Files 171 171
Lines 5758 5758
Branches 626 626
=======================================
Hits 3825 3825
Misses 1784 1784
Partials 149 149
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
* Adding in new test for parallel raise events in workflow Signed-off-by: Ryan Lettieri <ryanLettieri@microsoft.com>
* Adding in new test for parallel raise events in workflow Signed-off-by: Ryan Lettieri <ryanLettieri@microsoft.com>
* Adding in new test for parallel raise events in workflow Signed-off-by: Ryan Lettieri <ryanLettieri@microsoft.com> Signed-off-by: Hal Spang <halspang@microsoft.com>
* Adding in new test for parallel raise events in workflow Signed-off-by: Ryan Lettieri <ryanLettieri@microsoft.com> Signed-off-by: Hal Spang <halspang@microsoft.com> Co-authored-by: Ryan Lettieri <67934986+RyanLettieri@users.noreply.github.com>
* Adding in new test for parallel raise events in workflow Signed-off-by: Ryan Lettieri <ryanLettieri@microsoft.com>
* Adding in new test for parallel raise events in workflow Signed-off-by: Ryan Lettieri <ryanLettieri@microsoft.com>
Description
Previously, raising multiple events of the same name in parallel in workflow led to a series of events being incomplete. A change was made to durable task framework in the .NET SDK to fix this issue. This PR adds in a test to ensure that the fix works in this SDK as well.
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #[1129]
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: