set dapr-api-token to healthz requests when needed #1145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Fabian Martinez <46371672+famarting@users.noreply.github.com>
famarting
force-pushed
the
set-api-token-to-health-reqs
branch
from
7bfc18c
to
e53483c
Compare
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #1145 +/- ##
==========================================
- Coverage 66.47% 66.42% -0.05%
==========================================
Files 171 171
Lines 5754 5758 +4
Branches 624 626 +2
==========================================
Hits 3825 3825
- Misses 1782 1784 +2
- Partials 147 149 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. 📢 Have feedback on the report? Share it here. |
halspang
approved these changes
Sep 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implements the changes for #1144
I followed the same pattern that is used in
CreateInvokeMethodRequestwhich is the only other related to the use of the http client being used for the healthz requests.Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #1144
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list:
I think this changes don't require docs or test changes... existing tests and docs already cover this behaviour