Proposal: Change loglevel to Warning for duplicate priorities in pubsub topic subscriptions

[arnoldpistorius]

I have multiple TopicAttributes on the same topic with different filters. The priority of the filters doesn't matter, because they don't overlap. Without a priority on the attribute, the SDK will log the error below. In my opinion this should be warning instead of an error, because:

• The application continues execution and is functioning properly
• Monitoring tools will pick up the false-positive error

dotnet-sdk/src/Dapr.AspNetCore/DaprEndpointRouteBuilderExtensions.cs

Line 126 in e6ded69

logger.LogError("A subscription to topic {name} on pubsub {pubsub} has duplicate priorities for {priority}: found {count} occurrences.", first.Name, first.PubsubName, entry.Key, entry.Value);

Let me know what you think, I can submit a PR if you want.

[Yeg-A]

Do we have to explicitly assign priorities even in scenarios where that isn't relevant?

[BC89]

I'm seeing the same with the .Net SDK and don't really understand the intent of priorities as it seems required and necessarily unique which is odd.

[WhitWaldo]

Seems like an easy fix in that it's simply not factoring in matches into whether there are duplicates and looking only at component name, route name and priority to make that determination. Adding e.Match to the grouping here would limit showing the error only to those routes that share the same priority and match and thus overlap.