-
Notifications
You must be signed in to change notification settings - Fork 334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cloudeventsmiddleware has lost other properties of cloudevents #798
Comments
@saber-wang - Thanks for opening this issue! Are you just asking for additional properties to passed through to the subscription endpoint? Is this as opposed to providing them in the body of the message? |
@halspang I just don't think we should throw away other attributes |
@saber-wang - Circling back to this, if the raw cloud events doesn't work, I think it would be due to the runtime not actually passing the extra attributes through. If we want them here, we'd have to take care of it there first. |
I wanted to see if there is any workaround to access those cloud events attributes from request headers. I see that the current middleware does not capture all the attributes from the body and pass them into the header as specified in the their documents. |
@imranmomin At present, I have rewritten middleware and handled cloudevent properties myself |
I guess I will also have to rewrite the middleware |
It seems like this is becoming more popular. It might be beneficial to extend the cloudeventsmiddleware to avoid multiple implementations of the same functionality. Is this already captured in the backlog, and if so, could it be prioritized? |
Describe the proposal
dotnet-sdk/src/Dapr.AspNetCore/CloudEventsMiddleware.cs
Line 78 in cc1b097
Should additional attributes be attached to the request header?
The text was updated successfully, but these errors were encountered: