Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cloudeventsmiddleware has lost other properties of cloudevents #798

Open
saber-wang opened this issue Dec 10, 2021 · 8 comments
Open

Cloudeventsmiddleware has lost other properties of cloudevents #798

saber-wang opened this issue Dec 10, 2021 · 8 comments
Labels
question Further information is requested

Comments

@saber-wang
Copy link
Contributor

saber-wang commented Dec 10, 2021

Describe the proposal

var isDataSet = json.TryGetProperty("data", out var data);

Should additional attributes be attached to the request header?

@halspang
Copy link
Contributor

@saber-wang - Thanks for opening this issue! Are you just asking for additional properties to passed through to the subscription endpoint? Is this as opposed to providing them in the body of the message?

@halspang halspang added the question Further information is requested label Dec 20, 2021
@saber-wang
Copy link
Contributor Author

@halspang I just don't think we should throw away other attributes

@saber-wang
Copy link
Contributor Author

@halspang Currently, direct publishing of cloud events is supported #868 . Should this issue be reconsidered?

@halspang
Copy link
Contributor

@saber-wang - Circling back to this, if the raw cloud events doesn't work, I think it would be due to the runtime not actually passing the extra attributes through. If we want them here, we'd have to take care of it there first.

@imranmomin
Copy link

imranmomin commented Jul 21, 2022

@halspang @saber-wang

I wanted to see if there is any workaround to access those cloud events attributes from request headers. I see that the current middleware does not capture all the attributes from the body and pass them into the header as specified in the their documents.

https://github.com/cloudevents/spec/blob/v1.0.2/cloudevents/bindings/http-protocol-binding.md#313-metadata-headers

@saber-wang
Copy link
Contributor Author

saber-wang commented Jul 22, 2022

@imranmomin At present, I have rewritten middleware and handled cloudevent properties myself

@imranmomin
Copy link

I guess I will also have to rewrite the middleware

@zryska
Copy link

zryska commented Aug 4, 2024

It seems like this is becoming more popular. It might be beneficial to extend the cloudeventsmiddleware to avoid multiple implementations of the same functionality. Is this already captured in the backlog, and if so, could it be prioritized?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
Status: Backlog
Development

No branches or pull requests

4 participants