-
Notifications
You must be signed in to change notification settings - Fork 334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds an option to set a timeout for service invocation #1252
Conversation
Signed-off-by: Elena Kolevska <elena@kolevska.com>
Signed-off-by: Elena Kolevska <elena@kolevska.com>
Signed-off-by: Elena Kolevska <elena@kolevska.com>
Signed-off-by: Elena Kolevska <elena@kolevska.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1252 +/- ##
==========================================
+ Coverage 67.28% 67.31% +0.02%
==========================================
Files 174 174
Lines 6025 6030 +5
Branches 671 672 +1
==========================================
+ Hits 4054 4059 +5
Misses 1802 1802
Partials 169 169
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Elena Kolevska <elena@kolevska.com>
Signed-off-by: Elena Kolevska <elena@kolevska.com>
Signed-off-by: Elena Kolevska <elena@kolevska.com>
a3a92cd
to
23729fc
Compare
…tly to the call as shown in the updated tests and docs Signed-off-by: Elena Kolevska <elena@kolevska.com>
src/Dapr.Client/DaprClientBuilder.cs
Outdated
@@ -57,6 +57,7 @@ public DaprClientBuilder() | |||
// property exposed for testing purposes | |||
internal GrpcChannelOptions GrpcChannelOptions { get; private set; } | |||
internal string DaprApiToken { get; private set; } | |||
internal TimeSpan Timeout { get; private set; } // in milliseconds |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: remove comment? (No longer in milliseconds?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, thanks. Done!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one nit re: comments, otherwise looks good.
Signed-off-by: Elena Kolevska <elena-kolevska@users.noreply.github.com>
@holopin-bot @elena-kolevska Thanks Elena! 😁 |
Congratulations @elena-kolevska, you just earned a badge! Here it is: https://holopin.io/claim/clvdvlg1657300gji363rwirt This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account. |
hi guys, first of all thank you for this PR. I've build this version locally and it solved what I needed. Any idea on when this will be included in the release sir @philliphoff ? |
@taufan-mft It should be part of the v1.14 Dapr release. You can follow its progress in its release planning issue here: dapr/dapr#7605 |
thanks a lot! @philliphoff @elena-kolevska |
Description
Adds an option to set a timeout for http and grpc
Issue reference
#1007
Checklist