From d165b149552d5a4ba6c5cb2025a15989c12afbb5 Mon Sep 17 00:00:00 2001 From: Whit Waldo Date: Sun, 15 Sep 2024 21:21:46 -0500 Subject: [PATCH] Updated name of method so it wouldn't be as confusing why the developer would have two back-to-back invocations of SubscribeAsync (especially since it's not an async implementation at the Grpc client level. Signed-off-by: Whit Waldo --- .../PublishSubscribe/DaprPublishSubscribeClient.cs | 2 +- .../PublishSubscribe/DaprPublishSubscribeGrpcClient.cs | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/Dapr.Messaging/PublishSubscribe/DaprPublishSubscribeClient.cs b/src/Dapr.Messaging/PublishSubscribe/DaprPublishSubscribeClient.cs index 55669ad8..a50ef2c1 100644 --- a/src/Dapr.Messaging/PublishSubscribe/DaprPublishSubscribeClient.cs +++ b/src/Dapr.Messaging/PublishSubscribe/DaprPublishSubscribeClient.cs @@ -27,7 +27,7 @@ public abstract class DaprPublishSubscribeClient /// The delegate reflecting the action to take upon messages received by the subscription. /// Cancellation token. /// - public abstract IAsyncDisposable SubscribeAsync(string pubSubName, string topicName, DaprSubscriptionOptions options, TopicMessageHandler messageHandler, CancellationToken cancellationToken); + public abstract IAsyncDisposable Register(string pubSubName, string topicName, DaprSubscriptionOptions options, TopicMessageHandler messageHandler, CancellationToken cancellationToken); /// /// Gets the Dapr API token header for the given token value. diff --git a/src/Dapr.Messaging/PublishSubscribe/DaprPublishSubscribeGrpcClient.cs b/src/Dapr.Messaging/PublishSubscribe/DaprPublishSubscribeGrpcClient.cs index d0234905..3b0bc7a0 100644 --- a/src/Dapr.Messaging/PublishSubscribe/DaprPublishSubscribeGrpcClient.cs +++ b/src/Dapr.Messaging/PublishSubscribe/DaprPublishSubscribeGrpcClient.cs @@ -47,7 +47,7 @@ public DaprPublishSubscribeGrpcClient(P.DaprClient client) /// The delegate reflecting the action to take upon messages received by the subscription. /// Cancellation token. /// - public override IAsyncDisposable SubscribeAsync(string pubSubName, string topicName, DaprSubscriptionOptions options, TopicMessageHandler messageHandler, CancellationToken cancellationToken) + public override IAsyncDisposable Register(string pubSubName, string topicName, DaprSubscriptionOptions options, TopicMessageHandler messageHandler, CancellationToken cancellationToken) { var key = (pubSubName, topicName); if (clients.ContainsKey(key))