Removed custom concat implementation

Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com>
dapr · Aug 9, 2024 · a3a3e68 · a3a3e68
1 parent e002cee
commit a3a3e68
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 32 deletions.
diff --git a/src/Dapr.Actors.Generators/ActorClientGenerator.cs b/src/Dapr.Actors.Generators/ActorClientGenerator.cs
@@ -153,13 +153,13 @@ static void GenerateActorClientCode(SourceProductionContext context, ActorClient
                 .Select(member => GenerateMethodImplementation(member, actorMethodAttributeSymbol, cancellationTokenSymbol));
 
             var actorMembers = new List<MemberDeclarationSyntax>()
-                .Concat(actorProxyFieldDeclaration)
-                .Concat(actorCtor)
+                .Append(actorProxyFieldDeclaration)
+                .Append(actorCtor)
                 .Concat(actorMethods);
 
             var actorClientClassModifiers = new List<SyntaxKind>()
                 .Concat(SyntaxFactoryHelpers.GetSyntaxKinds(descriptor.Accessibility))
-                .Concat(SyntaxKind.SealedKeyword)
+                .Append(SyntaxKind.SealedKeyword)
                 .Select(sk => SyntaxFactory.Token(sk));
 
             var actorClientClassDeclaration = SyntaxFactory.ClassDeclaration(descriptor.ClientTypeName)

diff --git a/src/Dapr.Actors.Generators/Extensions/IEnumerableExtensions.cs b/src/Dapr.Actors.Generators/Extensions/IEnumerableExtensions.cs
@@ -30,17 +30,5 @@ internal static int IndexOf<T>(this IEnumerable<T> source, Func<T, bool> predica
 
             return -1;
         }
-
-        /// <summary>
-        /// Concatenates the specified item to the end of the sequence.
-        /// </summary>
-        /// <typeparam name="T"></typeparam>
-        /// <param name="source"></param>
-        /// <param name="item"></param>
-        /// <returns></returns>
-        internal static IEnumerable<T> Concat<T>(this IEnumerable<T> source, T item)
-        {
-            return source.Concat(new[] { item });
-        }
     }
 }
diff --git a/src/Dapr.Actors.Generators/Helpers/SyntaxFactoryHelpers.cs b/src/Dapr.Actors.Generators/Helpers/SyntaxFactoryHelpers.cs
@@ -1,5 +1,4 @@
-using Dapr.Actors.Generators.Extensions;
-using Microsoft.CodeAnalysis;
+using Microsoft.CodeAnalysis;
 using Microsoft.CodeAnalysis.CSharp;
 using Microsoft.CodeAnalysis.CSharp.Syntax;
 
@@ -99,7 +98,7 @@ public static InvocationExpressionSyntax ActorProxyInvokeMethodAsync(
             // Define the arguments to pass to the actor proxy method invocation.
             var proxyInvocationArguments = new List<ArgumentSyntax>()
                 // Name of remote method to invoke.
-                .Concat(SyntaxFactory.Argument(SyntaxFactory.LiteralExpression(SyntaxKind.StringLiteralExpression, SyntaxFactory.Literal(remoteMethodName))))
+                .Append(SyntaxFactory.Argument(SyntaxFactory.LiteralExpression(SyntaxKind.StringLiteralExpression, SyntaxFactory.Literal(remoteMethodName))))
                 // Actor method arguments, including the CancellationToken if it exists.
                 .Concat(remoteMethodParameters.Select(p => SyntaxFactory.Argument(SyntaxFactory.IdentifierName(p.Name))));
 

diff --git a/test/Dapr.Actors.Generators.Test/Extensions/IEnumerableExtensionsTests.cs b/test/Dapr.Actors.Generators.Test/Extensions/IEnumerableExtensionsTests.cs
@@ -48,19 +48,5 @@ public void IndexOf_WhenItemExists_ReturnsIndexOfItem(int[] source, int item, in
             // Assert
             Assert.Equal(expected, index);
         }
-
-        [Fact]
-        public void Concat_WhenItemIsNotNull_ReturnsConcatenatedSequence()
-        {
-            // Arrange
-            var source = new[] { "a", "b", "c" };
-            string item = "d";
-
-            // Act
-            var result = source.Concat(item);
-
-            // Assert
-            Assert.Equal(new[] { "a", "b", "c", "d" }, result);
-        }
     }
 }