Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guard by Default #3

Open
cyberience opened this issue Mar 1, 2019 · 0 comments
Open

Guard by Default #3

cyberience opened this issue Mar 1, 2019 · 0 comments

Comments

@cyberience
Copy link

Would it not be cleaner and use 1 less mapping if we were to set a default state variable, for example, defaultGuard = True
Then you only need to maintain a single list of excaptions to the default,
so if the default is Guard unless allowed, then the mapping would contain a white list, if the status is Allow, then it would be a black list.
Of course, having more states than a single logic would work, I just feel having 2 address arrays is additional storage that is not space efficient, and what would happen if a Single address managed to get into both lists? My years of development have taught me to only have single source of truth.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant