-
Notifications
You must be signed in to change notification settings - Fork 298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DAOS-14474,14219,14476,15049 dfs: dfs bug fixes #13646
Conversation
The dfs fs check command already allows evicting containers using the --flags=evict option. the --evict option was added by mistake and does not do anything today, so remove it. Signed-off-by: Mohamad Chaarawi <mohamad.chaarawi@intel.com>
The DFS checker should mark the symlink oid and not dereference the symlink value. the value can be invalid anyway and if a valid path in the container, it would be reachable from the hardlink path. Signed-off-by: Mohamad Chaarawi <mohamad.chaarawi@intel.com>
- In order to avoid stale root stat data, update the root stbuf on lookup. - add mtime/ctime proper querying for dfs_lookup() - destroy the uns container after the link is remove since dfuse looks up the root if the container of being destroyed. Required-githooks: true Signed-off-by: Mohamad Chaarawi <mohamad.chaarawi@intel.com>
…13640) - in dfs_osetattr(), if user sets both mtime and size, the hlc for the mtime is not being update on storage. To fix that, use the hlc reported from the array_stat and update that when updating the mtime in the entry. Signed-off-by: Mohamad Chaarawi <mohamad.chaarawi@intel.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. No errors found by checkpatch.
Bug-tracker data: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the go change looks good to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this run Features: dfs
?
Features: dfs Required-githooks: true Signed-off-by: Mohamad Chaarawi <mohamad.chaarawi@intel.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. No errors found by checkpatch.
yea.. unfortunately i forgot to do that since i just cherrypicked and that was removed from the master comment. anyway, repushed |
Test stage Functional on EL 8.8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-13646/2/execution/node/1121/log |
Before requesting gatekeeper:
Features:
(orTest-tag*
) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.Gatekeeper: