-
Notifications
You must be signed in to change notification settings - Fork 298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DAOS-14219 dfs: checker should not follow symlinks #13625
Conversation
The DFS checker should mark the symlink oid and not dereference the symlink value. the value can be invalid anyway and if a valid path in the container, it would be reachable from the hardlink path. Required-githooks: true Signed-off-by: Mohamad Chaarawi <mohamad.chaarawi@intel.com>
Bug-tracker data: |
I'm not sure why I got an email about this one as it's still draft and I'm not a reviewer but looks fine. I'll approve once marked ready for review. |
Test stage Functional Hardware Medium completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-13625/1/testReport/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You could also uncomment this line to enable this in the fault injection testing https://github.com/daos-stack/daos/blob/master/utils/node_local_test.py#L5936
Due to run-times we don't actually ever run that test however.
The DFS checker should mark the symlink oid and not dereference the symlink value. the value can be invalid anyway and if a valid path in the container, it would be reachable from the hardlink path. Signed-off-by: Mohamad Chaarawi <mohamad.chaarawi@intel.com>
* DAOS-14474 dfs: remove unused --evict option from checker (#13616) The dfs fs check command already allows evicting containers using the --flags=evict option. the --evict option was added by mistake and does not do anything today, so remove it. * DAOS-14219 dfs: checker should not follow symlinks (#13625) The DFS checker should mark the symlink oid and not dereference the symlink value. the value can be invalid anyway and if a valid path in the container, it would be reachable from the hardlink path. * DAOS-14476 dfs: update root stbuf on lookup of root (#13597) - In order to avoid stale root stat data, update the root stbuf on lookup. - add mtime/ctime proper querying for dfs_lookup() - destroy the uns container after the link is remove since dfuse looks up the root if the container of being destroyed. * DAOS-15049 dfs: fix bug in setattr when mtime and size are being set (#13640) - in dfs_osetattr(), if user sets both mtime and size, the hlc for the mtime is not being update on storage. To fix that, use the hlc reported from the array_stat and update that when updating the mtime in the entry. Signed-off-by: Mohamad Chaarawi <mohamad.chaarawi@intel.com>
The DFS checker should mark the symlink oid and not dereference the symlink value. the value can be invalid anyway and if a valid path in the container, it would be reachable from the hardlink path.
Required-githooks: true
Before requesting gatekeeper:
Features:
(orTest-tag*
) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.Gatekeeper: