-
Notifications
You must be signed in to change notification settings - Fork 298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DAOS-14718 test: Fix reading of DAOS_TEST_INSECURE_MODE envar (#13441) #13560
Conversation
The ConfigGenerateRun tests fail to use certs because insecure mode is enabled when trying to access non-existent DAOS_INSECURE_MODE env. Fix by updating env keyname to DAOS_TEST_INSECURE_MODE. Signed-off-by: Tom Nabarro <tom.nabarro@intel.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. No errors found by checkpatch.
Bug-tracker data: |
I've kicked off https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-13560/2/ to run control/config_generate_run.py (a weekly test not run with the default tags). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. No errors found by checkpatch.
@phender Jenkins seems to have passed but some of the checks seem to have not started, what should I do in this instance? |
Everything ran as intended and the build is complete. I kicked off a manual build to only run the |
@phender thanks for the response, so can we land this then please? |
The ConfigGenerateRun tests fail to use certs because insecure mode is
enabled when trying to access non-existent DAOS_INSECURE_MODE env. Fix
by updating env keyname to DAOS_TEST_INSECURE_MODE.
Before requesting gatekeeper:
Features:
(orTest-tag*
) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.Gatekeeper: