Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DAOS-14718 test: Fix reading of DAOS_TEST_INSECURE_MODE envar (#13441) #13560

Merged
merged 1 commit into from
Jan 18, 2024

Conversation

tanabarr
Copy link
Contributor

@tanabarr tanabarr commented Jan 3, 2024

The ConfigGenerateRun tests fail to use certs because insecure mode is
enabled when trying to access non-existent DAOS_INSECURE_MODE env. Fix
by updating env keyname to DAOS_TEST_INSECURE_MODE.

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate watchers.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

The ConfigGenerateRun tests fail to use certs because insecure mode is
enabled when trying to access non-existent DAOS_INSECURE_MODE env.
Fix by updating env keyname to DAOS_TEST_INSECURE_MODE.

Signed-off-by: Tom Nabarro <tom.nabarro@intel.com>
@tanabarr tanabarr requested a review from a team as a code owner January 3, 2024 19:47
@tanabarr tanabarr self-assigned this Jan 3, 2024
@tanabarr tanabarr requested a review from phender January 3, 2024 19:47
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

Copy link

github-actions bot commented Jan 3, 2024

Bug-tracker data:
Ticket title is 'ConfigGenerate tests failing due to certificate location issue'
Status is 'Awaiting backport'
Labels: 'ci_impact,weekly_test'
Job should run at elevated priority (1)
https://daosio.atlassian.net/browse/DAOS-14718

@github-actions github-actions bot added the priority Ticket has high priority (automatically managed) label Jan 3, 2024
@phender
Copy link
Contributor

phender commented Jan 4, 2024

I've kicked off https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-13560/2/ to run control/config_generate_run.py (a weekly test not run with the default tags).

Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

@tanabarr
Copy link
Contributor Author

tanabarr commented Jan 8, 2024

@phender Jenkins seems to have passed but some of the checks seem to have not started, what should I do in this instance?

@phender
Copy link
Contributor

phender commented Jan 9, 2024

@phender Jenkins seems to have passed but some of the checks seem to have not started, what should I do in this instance?

Everything ran as intended and the build is complete. I kicked off a manual build to only run the control/config_generate_run.py tests with https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-13560/2/parameters/ since the previous run did not run this test.

@tanabarr
Copy link
Contributor Author

tanabarr commented Jan 9, 2024

@phender thanks for the response, so can we land this then please?

@tanabarr tanabarr requested a review from a team January 9, 2024 14:41
@tanabarr tanabarr added the clean-cherry-pick Cherry-pick from another branch that did not require additional edits label Jan 9, 2024
@daltonbohning daltonbohning merged commit f13844d into release/2.4 Jan 18, 2024
42 checks passed
@daltonbohning daltonbohning deleted the tanabarr/test-insecure-mode-rel2_4 branch January 18, 2024 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clean-cherry-pick Cherry-pick from another branch that did not require additional edits priority Ticket has high priority (automatically managed)
Development

Successfully merging this pull request may close these issues.

4 participants