Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DAOS-14561 vos: Add garbage collection metrics (#13244) #13369

Merged
merged 5 commits into from
Jan 31, 2024
Merged

DAOS-14561 vos: Add garbage collection metrics (#13244) #13369

merged 5 commits into from
Jan 31, 2024

Conversation

mjmac
Copy link
Contributor

@mjmac mjmac commented Nov 21, 2023

  • Add some metrics for garbage collection
  • Add total metrics for vos space, so we can infer free space
  • Add aggregation failure counter

Also adds a small change to the Go builder for
handling versions with a -suffix.

Co-authored-by: Michael MacDonald mjmac@google.com
Signed-off-by: Jeff Olivier jeffolivier@google.com
Signed-off-by: Michael MacDonald mjmac@google.com

@jolivier23 @mjmac
DAOS-14561 vos: Add garbage collection metrics (#13244)
79d5230 
* Add some metrics for garbage collection
* Add total metrics for vos space, so we can infer free space
* Add aggregation failure counter

Also adds a small change to the Go builder for
handling versions with a -suffix.

Co-authored-by: Michael MacDonald <mjmac@google.com>
Signed-off-by: Jeff Olivier <jeffolivier@google.com>
Signed-off-by: Michael MacDonald <mjmac@google.com>
@mjmac mjmac requested review from a team as code owners November 21, 2023 18:35
daosbuild1
daosbuild1 reviewed Nov 21, 2023
View reviewed changes
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 21, 2023 •
edited
Loading

Bug-tracker data:
Ticket title is 'add garbage collection metrics'
Status is 'Awaiting backport'
Job should run at elevated priority (1)
https://daosio.atlassian.net/browse/DAOS-14561

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium Verbs Provider completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-13369/1/execution/node/1349/log

@daltonbohning
Copy link
Contributor

HW Medium failure looks to be
https://daosio.atlassian.net/browse/DAOS-14450
Which isn't yet backported to 2.4

@github-actions github-actions bot added the priority Ticket has high priority (automatically managed) label Dec 5, 2023
daosbuild1
daosbuild1 reviewed Dec 5, 2023
View reviewed changes
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium Verbs Provider completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-13369/2/execution/node/1297/log

@mjmac
Merge branch 'release/2.4' into mjmac/DAOS-14561-2.4
74548fd 
Change-Id: Ida920858a6258d3d2b5226a20f812fa6162d0cf9
@mjmac mjmac added the clean-cherry-pick Cherry-pick from another branch that did not require additional edits label Dec 29, 2023
daosbuild1
daosbuild1 reviewed Dec 29, 2023
View reviewed changes
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium Verbs Provider completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-13369/3/execution/node/1353/log

@mjmac mjmac requested a review from a team January 22, 2024 17:53
@mjmac mjmac added the forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed. label Jan 22, 2024
@mjmac
Merge branch 'release/2.4' into mjmac/DAOS-14561-2.4
7b29928 
Change-Id: I589ae28f55c772f15bf10e49c1cda9364bb4ea8d
daosbuild1
daosbuild1 reviewed Jan 22, 2024
View reviewed changes
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

@mjmac mjmac added the approved-to-merge PR has received release branch merge approval label Jan 25, 2024
@mjmac
Merge branch 'release/2.4' into mjmac/DAOS-14561-2.4
886f0c3 
Change-Id: Ifd86130ff3302e53784092e565c8f572fe08f4c1
daosbuild1
daosbuild1 reviewed Jan 25, 2024
View reviewed changes
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-13369/6/testReport/

@jolivier23 jolivier23 merged commit 56a186f into release/2.4 Jan 31, 2024
33 of 36 checks passed
@jolivier23 jolivier23 deleted the mjmac/DAOS-14561-2.4 branch January 31, 2024 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daosbuild1 daosbuild1 daosbuild1 left review comments

@jolivier23 jolivier23 jolivier23 approved these changes

Assignees
No one assigned
Labels
approved-to-merge PR has received release branch merge approval clean-cherry-pick Cherry-pick from another branch that did not require additional edits forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed. priority Ticket has high priority (automatically managed)
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mjmac @daosbuild1 @daltonbohning @jolivier23