Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Home Assistant Context API to avoid EC blocking itself (replaces grace_period) #193

Merged
merged 2 commits into from
Oct 1, 2020

Conversation

danobot
Copy link
Owner

@danobot danobot commented Sep 20, 2020

This PR replaces the implementation of grace_period introduced in # with the Context API. This allows EC to detect state changes that EC itself triggered by calling a services. These state changes are ignored by EC and therefore no longer interfere.

The configurable grace_period configuration will be deprecrated in this release.

Before opening a pull request, please ensure:

  • Double-check your branch is based on develop and targets develop
  • I have commented my code, particularly in hard-to-understand areas
  • The PR title is clear, concise and follows conventional commit formatting.
  • README documentation is updated for new features or changes in behaviour to existing features (VERY IMPORTANT, undocumented features cannot be discovered and used!)
  • Description explains the issue/use-case resolved and auto-closes related issues.
  • Breaking changes or changes in behaviour are called out and discussed in separate issues.

Be kind to code reviewers, please try to keep pull requests as small and focused as possible :)

IMPORTANT: By submitting a patch, you agree to allow the project owners to license your work under the terms of the project license.

Description

Related Issues

Closes #192

@danobot danobot merged commit 738968d into develop Oct 1, 2020
danobot added a commit that referenced this pull request Oct 23, 2020
…f (replaces grace_period) and ability to ignore event sources (#193)

* feat: Implement context for issue #192

* feat: ignored event sources #192

Co-authored-by: Daniel Mason <danielbaker210@gmail.com>
@danobot danobot deleted the issue/192 branch October 23, 2020 10:54
@danobot danobot restored the issue/192 branch October 23, 2020 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant