Skip to content
This repository has been archived by the owner on Oct 21, 2023. It is now read-only.

Creating a file for python shims #25

Open
qsniyg opened this issue Feb 28, 2017 · 1 comment
Open

Creating a file for python shims #25

qsniyg opened this issue Feb 28, 2017 · 1 comment

Comments

@qsniyg
Copy link
Collaborator

qsniyg commented Feb 28, 2017

There's a lot of places in the code where php->python shims are duplicated (simple example being Image.open(photo).size[0] to represent getimagesize(photo)[0], and a more complicated example would be the md5 functions), so I was wondering if creating a separate file to hold all those functions might be more efficient, and make the code look closer to the PHP counterpart.

@danleyb2
Copy link
Owner

Hello,
Hopping you've gone though the contribution guidelines and understood why the code pattern is as it is even though it hurts

If it will be encapsulating whole PHP functions and just return the same API as the PHP then its okay, i had started on something like that, you can take a look at https://github.com/danleyb2/Instagram-API/blob/master/InstagramAPI/src/Utils/php.py

I never wen't ahead since it took out project folder structure similarity

I give you a go ahead, i could gladly merge a PR on that,

Thank you

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants