Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expose pixel offsets in sprixel plane move, somehow #2313

Open
dankamongmen opened this issue Nov 2, 2021 · 1 comment
Open

expose pixel offsets in sprixel plane move, somehow #2313

dankamongmen opened this issue Nov 2, 2021 · 1 comment
Assignees
Labels
bitmaps bitmapped graphics (sixel, kitty, mmap) documentation Improvements or additions to documentation enhancement New feature or request

Comments

@dankamongmen
Copy link
Owner

In Kitty, it would be desirable to add the concept of pixel offset within a cell to our idea of moving graphics. Right now, smooth movement requires continuous redrawing, as the ncvisual_options struct is the only place you can express these offsets.

Of course, we don't want these in ncplane_move_yx(). We'd add some function which verifies that it is a sprixel plane, and then calls the internal mover.

This won't be of any benefit on Sixel, where we have to redraw in order to do smooth movement at all. It is thus independent of #2258 , and probably ought be added before 3.0.0 is finalized.

@dankamongmen dankamongmen added documentation Improvements or additions to documentation enhancement New feature or request bitmaps bitmapped graphics (sixel, kitty, mmap) labels Nov 2, 2021
@dankamongmen dankamongmen added this to the 3.0.0 milestone Nov 2, 2021
@dankamongmen dankamongmen self-assigned this Nov 2, 2021
@dankamongmen dankamongmen removed this from the 3.0.0 milestone Nov 2, 2021
@dankamongmen
Copy link
Owner Author

we can add functions whenever we want. even if it doesn't improve sixel, i'd still like it to be usable on sixel before publicizing it (though admittedly we didn't hold off for ncvisual_blit()).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bitmaps bitmapped graphics (sixel, kitty, mmap) documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant