Late naming for objects in OBJ loader #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Floppy
force-pushed
the
obj-loader-improvements
branch
from
d706c5b
to
799eac3
Compare
Floppy
force-pushed
the
obj-loader-improvements
branch
from
799eac3
to
c110708
Compare
|
This is good to go. I'll was thinking to fix the main issue in #123 here as well, but that's a bigger change that I need to take more time over, so I'll do it separately. I was thinking the object name fix would need a bigger change, but it didn't. |
danini-the-panini
approved these changes
Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handles late naming of first object in OBJ file. This happens in quite a few files found in the wild, where the first
odeclaration happens after the vertex list.Fixes a sub-issue identified in #123.