Split mittsu gem into mittsu-core and mittsu-renderer-opengl #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Floppy
force-pushed
the
separate-core-and-renderer-gems
branch
from
a64f5e1
to
e5e179e
Compare
|
Would we do this in subfolders, like Rails does? |
|
Also is this a patch or minor version bump, since it doesn't really change the interface |
|
Yeah, subfolders is probably a good idea. And you right, technically by semver it would be a patch version, as absolutely nothing would change! Hah. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an early PR for my attempt to resolve #115 by splitting mittsu into two gems. I think it can all be done in the same repo, and I've made it so that
mittsugem itself simply depends on the two component parts.I've kept a single version string, and made them depend on that exact version, to avoid any differences causing problems. Can always be split later on.