Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ignore autogenerated .jscs files #83

Merged
merged 1 commit into from
May 8, 2015

Conversation

GlennGeelen
Copy link
Contributor

When adding Broccoli-JSCS to our Ember project, Ember-data-factory-guy breaks our app because it doesn't filter the auto generated JSCS files. This only occurred with the following setting for broccoli-jscs in the broccoli.js.

jscsOptions: {
  enabled: true,
  disableTestGenerator: false
}

With this PR the Ember app also ignores the auto generated files made by Broccoli-JSCS.

@danielspaniel
Copy link
Collaborator

Your reminding me that I did not like that setup in the first place .. need to find a better way to import the factory files and only the factory files. Can you think of a better way to do it ( off the top of your head ) before I merge this?

@GlennGeelen
Copy link
Contributor Author

No not right now but I'll think about it, maybe I'll come up with something.

@danielspaniel
Copy link
Collaborator

Ok .. I am going to ponder it again too .. want me to merge this and make new patch version in the meantime?

@GlennGeelen
Copy link
Contributor Author

Yes please.

danielspaniel added a commit that referenced this pull request May 8, 2015
ignore autogenerated .jscs files
@danielspaniel danielspaniel merged commit d9b425a into adopted-ember-addons:master May 8, 2015
@danielspaniel
Copy link
Collaborator

new version 1.0.8 is ready

@GlennGeelen
Copy link
Contributor Author

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants