Use assert rather than warn for missing traits #266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lorcan
force-pushed
the
lorcan/assert-fail-on-missing-traits
branch
from
67a257a
to
3e03303
Compare
lorcan
commented
Dec 15, 2016
| @@ -263,7 +263,7 @@ test("with errors in response", function(assert) { | |||
| const done = assert.async(); | |||
|
|
|||
| const response = { errors: { description: ['bad'] } }; | |||
| const mock = mockFindRecord('profile', 1).fails({ response }); | |||
| const mock = mockFindRecord('profile').fails({ response }); | |||
There was a problem hiding this comment.
Funnily the change exposed this
WARNING: [ember-data-factory-guy] You're trying to use a trait [1] for model profile but that trait can not be found.
There was a problem hiding this comment.
oooo .. that is so interesting .. that is vestige of past , the way it was used .. good catch ..
| @@ -263,7 +263,7 @@ test("with errors in response", function(assert) { | |||
| const done = assert.async(); | |||
|
|
|||
| const response = { errors: { description: ['bad'] } }; | |||
| const mock = mockFindRecord('profile', 1).fails({ response }); | |||
| const mock = mockFindRecord('profile').fails({ response }); | |||
There was a problem hiding this comment.
oooo .. that is so interesting .. that is vestige of past , the way it was used .. good catch ..
|
was there another thing you were going to use assert for .. you want to do that one and then I put that out in next 2.10 release ? |
|
Yeah was hoping to complete #264 alongside but it got a little involved... It'll probably be next week before I get back to it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We kinda discussed using assertions rather than warnings for missing traits in another PR. I decided to spike this out.
If this is merged it might be worth flagging this - maybe this change is bigger than a patch release. It's possible it will cause test failures for people where before they were seeing (but perhaps not noticing or acting on) warnings that were there all along.