Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for using factory-guy in other environments #255

Merged
merged 6 commits into from
Oct 25, 2016

Conversation

juwara0
Copy link
Contributor

@juwara0 juwara0 commented Oct 25, 2016

Closes: #254

CHANGELOG:
Updated index.js to support using factory-guy in other environments
Updated README to show configuration needed for using factory-guy in other environments

DESCRIPTION:
This PR adds support for using factory-guy in other environments to the base cases of development and test.

The user just needs to add:

// file: config/environment.js
ENV.factoryGuy = true;

to the environments in which factory-guy is desired.

By default, the test environment is still enabled but now a user can turn it off by specifying:

// file: config/environment.js
if (environment === 'test') {
  ENV.factoryGuy = false;
  ...
}

@danielspaniel
Copy link
Collaborator

Looks good Michael
I was just about to ask how this was going. Ok .. one question.
The only caveat is to make sure in test environment to not put => factoryGuy:true .. or else it would look for the scenarios/main.js file and barf if not found.

@juwara0
Copy link
Contributor Author

juwara0 commented Oct 25, 2016

@danielspaniel - I have added a note to the README to highlight that factoryGuy: true should not be added to the test environment.

@danielspaniel danielspaniel merged commit 9322a53 into adopted-ember-addons:master Oct 25, 2016
@danielspaniel
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants