Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding factories to the app instead #211

Merged

Conversation

taras
Copy link
Contributor

@taras taras commented Jun 16, 2016

I don't know if this is the right solution but it seems like it could be. I tried to test it, but the demo app's index.html has all of it's code commented out. Why is that?

@danielspaniel
Copy link
Collaborator

You know that is a great question .. why is that index.html code commented out? I have no idea?

@taras
Copy link
Contributor Author

taras commented Jun 16, 2016

It looks like you commented it out here 3a15f09

@danielspaniel
Copy link
Collaborator

Just forgot what was going on there? I will fix that

@danielspaniel
Copy link
Collaborator

please uncomment that if that helps you test it ..

@danielspaniel
Copy link
Collaborator

I am testing your idea now

@danielspaniel
Copy link
Collaborator

danielspaniel commented Jun 16, 2016

not working .. seems close though
it is interesting because it creates that directory factories with the factories in them
I can tell because when I modify a factory file I get:

file changed post.js
file changed factories/post.js

so the file is in 2 funnels being watched

but where is that file being placed? that is the $100,000 question .. checking now if it is in the assets/app.js file

@danielspaniel
Copy link
Collaborator

danielspaniel commented Jun 16, 2016

wait .. take that back .. they are in the assets.[appname].js file ..
I think the only thing missing now is to require them because they don't get loaded unless they are required .. which is what factory guy manual setup does .. goes through the files and requires them
so .. wow .. awesome dude .. I think you did that in 10 minutes ? .. amazing

@taras
Copy link
Contributor Author

taras commented Jun 16, 2016

:) I'm glad it did the trick. Do you need anything else?

@danielspaniel
Copy link
Collaborator

yes, can you explain about the microstates sometime to me .. me want to understand more about that .. I don't quite get it

@taras
Copy link
Contributor Author

taras commented Jun 16, 2016

Let's do a little screenshare and I'll show you how it works.

@danielspaniel
Copy link
Collaborator

danielspaniel commented Jun 16, 2016

let me know when you want to do that .. i can do anytime

@danielspaniel danielspaniel merged commit 7108bc4 into adopted-ember-addons:factories-in-dev Jun 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants