Multiple calls to handleCreate() don't work

[benlieb]

I have a test file with multiple test() calls. Inside two I have calls to handleCreate(). Each test run individually succeeds, but together they fail since only the first call to handleCreate() "takes" or "sticks".

https://gist.github.com/pixelterra/cd4e6d7ac3e4794bdf58

This is pretty surprising behavior to me. I would assume that only the "last" call to handleCreate() would be "active".

I suppose that I could work around this by using the match() method and tracking which data is used in each call, but this seems unnecssary and could get messy with many calls to handleCreate().

Is this the only option or am I missing something?

[danielspaniel]

I'll make this a puzzle for you @pixelterra

Check out the sample acceptance test from the docs, and see if you can spot what you forgot to add to your test.

Hints provided if you don't get it in 30 seconds.

[benlieb]

Ah setup teardown. :) Lemme give that a go...

[benlieb]

Ooo. that broke everything :(

[danielspaniel]

Yikes .. really .. hmm .. now I am puzzled.

[benlieb]

I'm on 0.2.3 btw

[danielspaniel]

Me too, but let me check that gist again.

[benlieb]

Error: Assertion Failed: You cannot use the same root element (#ember-testing) multiple times in an Ember.Application
afterEach failed on fields exist and are empty initally: No model was found for 'test'
afterEach failed on registration fails with bad data, and appropriate errors are displayed: No model was found for 'test'
etc...

[benlieb]

Updated gist:
https://gist.github.com/pixelterra/cd4e6d7ac3e4794bdf58

[danielspaniel]

I think I know the reason.

Get newest version of ember-data-factory-guy ..

First:
remove it from package.json file
then:
npm prune
then:
ember install ember-data-factory-guy

[benlieb]

I have "ember-data-factory-guy": "1.0.2",
should I have a newer one?

[danielspaniel]

Yes, 1.0.3

[danielspaniel]

Hmm .. tricky .. actually 1.0.2 should work ok .. but if you get 1.0.3 .. at least you'll be on the same page as I am, so I can help out easier.

[benlieb]

hm

[danielspaniel]

Yeah . I know .. sounds fishy.

[benlieb]

installing now

[benlieb]

actually going to standup with my team in a sec...

[benlieb]

but I have 2 mins

[benlieb]

actually that seems to have fixed everything

[benlieb]

is this setup() and teardown() for FG new?

[danielspaniel]

no .. it's been there ( in that FactoryGuyTestHelper ) .. for ever ..

[benlieb]

well for whatever reason, that fixed everything...

[danielspaniel]

whew .. glad that worked .. I was starting to think my fingernails were getting tasty there for a second.
I know why it worked .. but glad it's sorted out.
Essentially, you have to call $.mockjax.clear() ( to clear the old mockjax handlers )
which is what the teardown method is doing for you.
the setup call is setting up the response time for mockjax to 0 .. so that will speed up your tests ( that use mockjax ) quite alot.

[danielspaniel]

So, just for fun, try omitting the setup, and you'll see that those last 3 tests run slower

[danielspaniel]

This discussion actually showed me a bug .. which I fixed, and pushed out a new version 1.0.4.
You might not encounter it, but its safer to upgrade to this version so you don't get surprised.

[danielspaniel]

Closing this since issue resolved.