Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecation warnings on Ember 2.8 #250

Closed
mdentremont opened this issue Sep 19, 2016 · 6 comments
Closed

Deprecation warnings on Ember 2.8 #250

mdentremont opened this issue Sep 19, 2016 · 6 comments

Comments

@mdentremont
Copy link
Contributor

mdentremont commented Sep 19, 2016 •
edited
Loading

It looks like Django 1.10 has introduced an includes method to the array class, and deprecated the contains method.

There are a couple usages of contains in the test helpers which are leading to some deprecation warnings on the new version.
@danielspaniel
Copy link
Collaborator

I will fix that today .. thanks for letting me know ( it is also deprecated in ember 2.8 )

@mdentremont mdentremont changed the title Deprecation warnings on Django 1.10 Deprecation warnings on Ember 2.8 Sep 19, 2016
@mdentremont
Copy link
Contributor Author

@danielspaniel Haha my bad - too much context switching :P

@mdentremont
Copy link
Contributor Author

mdentremont commented Sep 19, 2016 •
edited
Loading

@danielspaniel Feel free to use #251 if you're happy with it

@danielspaniel
Copy link
Collaborator

Appreciate the pull request .. I put comment there about just replacing contains to includes with no conditional logic

@mdentremont
Copy link
Contributor Author

Thanks @danielspaniel !

@danielspaniel
Copy link
Collaborator

https://github.com/danielspaniel/ember-data-factory-guy/releases/tag/v2.7.10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@danielspaniel @mdentremont