findRecord giving error "Cannot read property '_internalModel' of undefined" #136

swatijadhav · 2015-10-01T11:10:22Z

In our ember app, we are using following versions of ember-data and ember-data-factory-guy.

package.json

"ember-cli": "^1.13.8",
"ember-data": "1.13.9",
"ember-data-factory-guy": "1.13.10",

Note: we are using active-model adapter, not yet migrated to the json-api adapter.

import ActiveModelAdapter from 'active-model-adapter';
export default ActiveModelAdapter.extend({

Route: item.js

export default Ember.Route.extend(({
  model(params) {
    return this.store.findRecord('item', params.item_id);
  }
});

Its working fine in development mode, but while running test cases, am facing following issue:

Test Case for "display single item" fails with following error:

{
  "message": "Cannot read property '_internalModel' of undefined",
  "name": "TypeError"
}

ember-data/lib/system/stpre/finder.js, fails at return statement

  return promise.then(function (adapterPayload) {
    Ember.assert("You made a request for a " + typeClass.typeClassKey + " with id " + id + ", but the adapter's response did not have any data", adapterPayload);
    return store._adapterRun(function () {
      var requestType = get(serializer, 'isNewSerializerAPI') ? 'findRecord' : 'find';
      var payload = normalizeResponseHelper(serializer, store, typeClass, adapterPayload, id, requestType);
      //TODO Optimize
      var record = pushPayload(store, payload);
      return record._internalModel;
    });

(https://github.com/emberjs/data/blob/master/packages/ember-data/lib/system/store/finders.js#L32)

Are we missing anything here? Can anyone please help me to resolve this? I have tried by upgrading versions to latest, but still facing same issue.

The text was updated successfully, but these errors were encountered:

danielspaniel · 2015-10-01T12:14:48Z

This issue is missing a few key details @swatijadhav.
Like:

What does your test look like? ( most important )
What does model and factory look like?

swatijadhav · 2015-10-01T12:46:26Z

item model:

import Ember from 'ember';
import DS from 'ember-data';
var attr = DS.attr,
    belongsTo = DS.belongsTo;
export default DS.Model.extend({
  donorDescription:     attr('string'),
  state:                attr('string'),
  offer:                belongsTo('offer', { async: false })
})

item factory:

import FactoryGuy from 'ember-data-factory-guy';
import './offer';
FactoryGuy.define('item', {
  sequences: {
    id: function(num) {
      return num + 100;
    },
    description: function(num) {
      return 'Donor Description' + num;
    }
  },
  default: {
    id:               FactoryGuy.generate('id'),
    state:            'submitted',
    donorDescription: FactoryGuy.generate("description"),
  },
});
export default {};

test case:

import Ember from 'ember';
import startApp from '../helpers/start-app';
import syncDataStub from '../helpers/empty-sync-data-stub';
import FactoryGuy from 'ember-data-factory-guy';
import TestHelper from 'ember-data-factory-guy/factory-guy-test-helper';
var App, store, offer1, item1;
module('Donor: Display Item Status', {
  setup: function() {
    App = startApp();
    TestHelper.setup();
    store = TestHelper.getStore();
    syncDataStub(TestHelper);
    offer1 = FactoryGuy.make("offer", {state:"submitted"});
    item1 = FactoryGuy.make("item", {offer: offer1, state:"submitted"});
  },
  teardown: function() {
    Em.run(function() { TestHelper.teardown(); });
    Ember.run(App, 'destroy');
  }
});
test("Display item status for submitted item", function() {
  visit('/offers/' + offer1.id + "/items/"+ item1.id +"/messages");
  andThen(function() {
    equal(currentURL(), '/offers/' + offer1.id + "/items/"+ item1.id +"/messages");
    equal($.trim(find('.status-message').text()), "This item is awaiting review.");
  });
});

swatijadhav · 2015-10-01T12:57:47Z

While inspecting further, came to know that in ember-data/lib/system/store/serializer-response.js file, inside function normalizeResponseHelper

get(serializer, 'isNewSerializerAPI')

this value is evaluated as false.

For the same function normalizeResponseHelper, it is given that

/**
  This is a helper method that always returns a JSON-API Document.
  If the current serializer has `isNewSerializerAPI` set to `true`
  this helper calls `normalizeResponse` instead of `extract`.
  All the built-in serializers get `isNewSerializerAPI` set to `true` automatically
  if the feature flag is enabled.

So I added it

export default ActiveModelAdapter.extend({
  isNewSerializerAPI: true,

But still facing same issue.

danielspaniel · 2015-10-01T12:59:34Z

do me a favour and do this:

import FactoryGuy from 'ember-data-factory-guy';
import './offer'; // why? maybe you don't need?

FactoryGuy.define('item', {
  sequences: {
    description: function(num) {
      return 'Donor Description' + num;
    }
  },
  default: {
    state:            'submitted',
    donorDescription: FactoryGuy.generate("description"),
  },
});
export default {};

for your test ( get rid of the id line ) ..

swatijadhav · 2015-10-01T13:08:14Z

Thanks for the response @danielspaniel
Tried above suggestion, but it does not work. :(

danielspaniel · 2015-10-01T13:08:27Z

@swatijadhav ... can you send me your router code too .. curious

also curious to see what you get for:

export default Ember.Route.extend(({
  model(params) {
    console.log( this.store.peekAll('item').get('content').length)
    var item = this.store.findRecord('item', params.item_id);
    console.log(params, item);
    return item;
  }
});

like what the store is returning? check network. should not be doing network call .. should go to store and get the item ( assuming you have the right id .. which you should base on your test )
my guess is something in routes maybe?

danielspaniel · 2015-10-01T13:13:02Z

then right after your test code here:

test("Display item status for submitted item", function() {
  console.log(item1) // see if there is '_internalModel' property on item1
  visit('/offers/' + offer1.id + "/items/"+ item1.id +"/messages");

swatijadhav · 2015-10-01T13:15:18Z

In router.js, I have following:

  this.resource('offers', function () {
    this.resource('offer', { path: '/:offer_id'}, function() {
      this.resource('item', {path: '/items/:item_id'}, function() {
        this.route('index', { path: '/'});
      });
    });
  });

swatijadhav · 2015-10-01T13:17:14Z

yes, it gets 'item1._internalModel' value

  item1._internalModel
  InternalModel {id: "101", store: Class, container: Container, _data: Object, modelName: "item".....

danielspaniel · 2015-10-01T14:27:19Z

what about this one:

export default Ember.Route.extend(({
  model(params) {
    console.log( this.store.peekAll('item').get('content').length)
    var item = this.store.findRecord('item', params.item_id);
    console.log(params, item+'');
    return item;
  }
});

what do you get for those console statements

swatijadhav · 2015-10-01T14:33:55Z

4
Object {item_id: "101"} "<DS.PromiseObject:ember765>"

danielspaniel · 2015-10-01T14:36:33Z

hmm .. 4 is odd .. should be 1, but the rest is good
how about: replace the first console with:
console.log( this.store.peekAll('item').get('content').mapBy('id') )

swatijadhav · 2015-10-01T14:40:24Z

the count is 4 because we have created some more data for other test cases in same file.. so we can neglect that

- ["101", "102", "103", "104"]
0: "101"
1: "102"
2: "103"
3: "104"
length: 4__proto__: Array[0]
- Object {item_id: "101"} "<DS.PromiseObject:ember765>"

danielspaniel · 2015-10-01T14:45:13Z

ok .. so replace

console.log(params, item+'');

with

item.then(function(model) {
  console.log(model+'', model.get('offer')+'')
});

danielspaniel · 2015-10-01T14:46:47Z

though what is really troubling me is that there should not be a payload at all .. since it should be getting the item from the store and returning that one. so I am wondering if you get any network calls when you run this test ( developer tools on chrome .. network tab )

danielspaniel · 2015-10-01T14:49:16Z

because if there is an error here:

  return promise.then(function (adapterPayload) {
    Ember.assert("You made a request for a " + typeClass.typeClassKey + " with id " + id + ", but the adapter's response did not have any data", adapterPayload);
    return store._adapterRun(function () {
      var requestType = get(serializer, 'isNewSerializerAPI') ? 'findRecord' : 'find';
      var payload = normalizeResponseHelper(serializer, store, typeClass, adapterPayload, id, requestType);
      //TODO Optimize
      var record = pushPayload(store, payload);
      return record._internalModel;
    });

that means the store went and did an ajax find to get the json .. odd .. isn't it?
boy .. I am curious to see what you get if you put a console statement there
after
// TODO Optimize
console.log(payload) // what could that payload be I wonder?

swatijadhav · 2015-10-01T14:53:34Z

> payload
Object {data: null}

danielspaniel · 2015-10-01T14:54:35Z

that is super interesting .. well .. is there a network call?

swatijadhav · 2015-10-01T14:55:31Z

yes
http://localhost:4200/api/v1/items/101

swatijadhav · 2015-10-01T14:56:10Z

Check this issue emberjs/data#3757

danielspaniel · 2015-10-01T14:57:52Z

hmm .. fascinating .. that should not be happening .. and good find there from ember-data ticket

swatijadhav · 2015-10-01T15:00:45Z

any workaround for this issue? any suggestions?
Reverting it back from findRecord to find, gives same issue..

danielspaniel · 2015-10-01T15:03:21Z

hmm .. I guess that concept of preloading the store might be unreliable.
I reckon, you could get around that ... but using the helpers
TestHelper.handleFind('item_with_offer')

module('Donor: Display Item Status', {
  setup: function() {
    App = startApp();
    TestHelper.setup();
    store = TestHelper.getStore();
    syncDataStub(TestHelper);
  },

  teardown: function() {
    Em.run(function() { 
     TestHelper.teardown(); 
     App.destroy() 
    });
  }
});

test("Display item status for submitted item", function() {
  var item = TestHelper.handleFind('item', 'is_submitted', 'has_submitted_offer');
  visit('/offers/' + 1 + "/items/"+ item1.id +"/messages");

  andThen(function() {
    equal(currentURL(), '/offers/1/items/"+ item1.id +"/messages");
    equal($.trim(find('.status-message').text()), "This item is awaiting review.");
  });
});

danielspaniel · 2015-10-01T15:05:24Z

 see better detail here
// using traits here to make a submitted item with a submitted offer
var itemId = TestHelper.handleFind('item', 'is_submitted', 'has_submitted_offer');
var offerId = 1; // assumes you let FactoryGuy make the offer
visit('/offers/' + offerId + "/items/"+ itemIid +"/messages");

danielspaniel · 2015-10-01T15:07:30Z

though your default is state ( submitted ) for offers and items .. so that might seem redundant .. but I think you know what I mean .. right?

swatijadhav · 2015-10-01T15:11:40Z

yeah, got your point..
But here it will fix only one specific test..I have other many tests which failing due to findRecord
I will try out the above suggestion and will update it here..

swatijadhav · 2015-10-02T16:26:47Z

Finally got the exact cause:

In my adapter/application.js

// Ember Data 2.0 Reload behavior
shouldReloadRecord: function() { return true; },
shouldReloadAll: function() { return true; },
shouldBackgroundReloadRecord: function() { return true; },
shouldBackgroundReloadAll: function() { return true; },

These lines I had added while fixing deprecation warnings, and because of this, it was causing records to be loaded always, although they were present in ember-data store. So now I just removed those.

Thank you very much for all the help.. 😄

danielspaniel · 2015-10-02T16:32:45Z

great news @swatijadhav .. really happy you are back in business, and I am glad you posted this to help others with similar problem

swatijadhav · 2015-10-02T16:34:12Z

Thanks 👍

neeraj-joshi01 · 2015-12-12T16:57:16Z

Getting this error "Cannot read property '_internalModel' of undefined" on this.store.find('user',1) or this.store.findRecord('user',1).
Here is my bower.json,
{
"name": "frontend",
"dependencies": {
"ember": "1.13.11",
"ember-cli-shims": "0.0.6",
"ember-cli-test-loader": "0.2.1",
"ember-data": "1.13.15",
"ember-load-initializers": "0.1.7",
"ember-qunit": "0.4.16",
"ember-qunit-notifications": "0.1.0",
"ember-resolver": "~0.1.20",
"jquery": "^1.11.3",
"loader.js": "ember-cli/loader.js#3.4.0",
"qunit": "~1.20.0",
"bootstrap": "~3.3.6"
}
}

danielspaniel · 2015-12-12T17:52:22Z

huh? .. what you talkin bout willis?

neeraj-joshi01 · 2015-12-12T18:03:47Z

Here is my application adapter :
import ActiveModelAdapter from 'active-model-adapter'

export default ActiveModelAdapter.extend({})

Here is the application serializer:

import { ActiveModelSerializer } from 'active-model-adapter'

export default ActiveModelSerializer.extend()

danielspaniel · 2015-12-12T18:05:10Z

sorry ... I have no idea what you are talking about .. too little info

neeraj-joshi01 · 2015-12-12T18:06:24Z

what do you want me to give you? Here is the code snippet which throws this error
that.store.find('user',response.id).then(
(user)->
that.get('session').set('currentUser',user)
that.transitionToRoute('home')
)

danielspaniel · 2015-12-12T18:08:41Z

so .. pretend you were me and this is all you had to look at .. you tell me how you would fix it? cause if you could .. maybe you are some kind of genius and I will bow before you.

neeraj-joshi01 · 2015-12-12T18:10:08Z

what more information you want me to give you ? can you specify that ?

danielspaniel · 2015-12-12T18:13:05Z

no .. I want you to figure it out alittle bit .. because you don't seem to be able to understand what it is like for me .. so think more about it

swatijadhav closed this as completed Oct 2, 2015

findRecord giving error "Cannot read property '_internalModel' of undefined" #136

findRecord giving error "Cannot read property '_internalModel' of undefined" #136

Comments

swatijadhav commented Oct 1, 2015

danielspaniel commented Oct 1, 2015

swatijadhav commented Oct 1, 2015

swatijadhav commented Oct 1, 2015

danielspaniel commented Oct 1, 2015

swatijadhav commented Oct 1, 2015

danielspaniel commented Oct 1, 2015

danielspaniel commented Oct 1, 2015

swatijadhav commented Oct 1, 2015

swatijadhav commented Oct 1, 2015

danielspaniel commented Oct 1, 2015

swatijadhav commented Oct 1, 2015

danielspaniel commented Oct 1, 2015

swatijadhav commented Oct 1, 2015

danielspaniel commented Oct 1, 2015

danielspaniel commented Oct 1, 2015

danielspaniel commented Oct 1, 2015

swatijadhav commented Oct 1, 2015

danielspaniel commented Oct 1, 2015

swatijadhav commented Oct 1, 2015

swatijadhav commented Oct 1, 2015

danielspaniel commented Oct 1, 2015

swatijadhav commented Oct 1, 2015

danielspaniel commented Oct 1, 2015

danielspaniel commented Oct 1, 2015

danielspaniel commented Oct 1, 2015

swatijadhav commented Oct 1, 2015

swatijadhav commented Oct 2, 2015

danielspaniel commented Oct 2, 2015

swatijadhav commented Oct 2, 2015

neeraj-joshi01 commented Dec 12, 2015

danielspaniel commented Dec 12, 2015

neeraj-joshi01 commented Dec 12, 2015

danielspaniel commented Dec 12, 2015

neeraj-joshi01 commented Dec 12, 2015

danielspaniel commented Dec 12, 2015

neeraj-joshi01 commented Dec 12, 2015

danielspaniel commented Dec 12, 2015