From 635fb0cbc207b16553f7c74192741bf3afd9f35f Mon Sep 17 00:00:00 2001 From: Daniel Sogl Date: Sun, 7 May 2017 18:32:42 +0200 Subject: [PATCH 1/2] refactor(social sharing): added missing method fix #1288 --- src/@ionic-native/plugins/social-sharing/index.ts | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/src/@ionic-native/plugins/social-sharing/index.ts b/src/@ionic-native/plugins/social-sharing/index.ts index 82e2f7cf23..8f9a5b2d77 100644 --- a/src/@ionic-native/plugins/social-sharing/index.ts +++ b/src/@ionic-native/plugins/social-sharing/index.ts @@ -211,4 +211,14 @@ export class SocialSharing extends IonicNativePlugin { platforms: ['iOS', 'Android'] }) shareVia(appName: string, message: string, subject?: string, image?: string, url?: string): Promise { return; } + + /** + * defines the popup position before call the share method. + * @param targetBounds {string} left,top,width,height + */ + @Cordova({ + sync: true, + platforms: ['iOS'] + }) + setIPadPopupCoordinates(targetBounds: string): void { } } From 51140a8c02d308d90b24595b64edc2196ee4b37a Mon Sep 17 00:00:00 2001 From: Daniel Sogl Date: Sun, 7 May 2017 18:45:35 +0200 Subject: [PATCH 2/2] Update index.ts --- src/@ionic-native/plugins/social-sharing/index.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/@ionic-native/plugins/social-sharing/index.ts b/src/@ionic-native/plugins/social-sharing/index.ts index 8f9a5b2d77..039627eb93 100644 --- a/src/@ionic-native/plugins/social-sharing/index.ts +++ b/src/@ionic-native/plugins/social-sharing/index.ts @@ -214,7 +214,7 @@ export class SocialSharing extends IonicNativePlugin { /** * defines the popup position before call the share method. - * @param targetBounds {string} left,top,width,height + * @param targetBounds {string} left, top, width, height */ @Cordova({ sync: true,