Don’t use _all_ HTML entities in tests #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It does indeed fix #14. It would be nice to continue testing all entities since that’s why I built this crate, but I think keeping tests functional is more important. |
Building matchers for all HTML entities can be a bit much for limited hosts, e.g. micro VMs or limited Docker containers. This removes most of the HTML entities; it only keeps entites that are all lowercase and whose names start with one of `[aglqt]`. This also fixes #14 (tests fail to build in Docker), so it removes the existing work-around. This resets all benchmarks.
danielparks
force-pushed
the
fewer-entities
branch
from
8ca0571
to
227871a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building matchers for all HTML entities can be a bit much for limited hosts, e.g. micro VMs or limited Docker containers. This removes most of the HTML entities; it only keeps entites that are all lowercase and whose names start with one of
[aglqt].To do