Bugfix/pie highlight #4272
Merged
Bugfix/pie highlight #4272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #3996, As that PR made normal slices render through highlight code, while disabling shift. So special highlight colors or other styling - would still affect the normal rendering.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Link 🔗
#3996
Goals ⚽
The original PR made normal slices render through the highlight code, while disabling slice-shift.
So special highlight colors or other styling - would still affect the normal rendering.
Implementation Details 🚧
Avoid rendering highlights when rendering dataset, avoid rendering non-highlighted slices when rendering highlights.
Testing Details 🔍
Manually.