Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Channel recording would not stop #60

Closed
TomWocken opened this issue Feb 18, 2022 · 3 comments
Closed

Channel recording would not stop #60

TomWocken opened this issue Feb 18, 2022 · 3 comments
Assignees
Labels

Comments

@TomWocken
Copy link

I can start bridge and channel recordings, but only bridge recordings can be stopped.
On channels the stop command would succeed but then not actually work.
After this a channel play would also fail.

I found one missing character, after digging through Asterisk debug logs, that actually fixes everything.
My company prefers I not submit patches but I could not leave you hanging.
Beside you probably want to consider if anything else needs to be done.

In your channel.h line 360 change Recording recording(name, client); to Recording recording(_name, client);

aricpp-1.1.1 and Asterisk 18.9.0

@daniele77 daniele77 self-assigned this Feb 21, 2022
@daniele77 daniele77 added the bug label Feb 21, 2022
@daniele77
Copy link
Owner

Thank you very much, @TomWocken for your report.
I applied the fix you suggest, and now it should work as expected.
I did a new release v. 1.1.2.
Please, check out the new release, and feel free to give me feedback.

@TomWocken
Copy link
Author

I tested 1.1.2 and all is well.
I appreciate your quick reaction.
(And the use of a better variable than "_name")

@daniele77
Copy link
Owner

Yeah, as you can see good naming avoids certain kinds of bugs!
Thank you very much

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants