Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update comment that says xhr hack is for angular <1.2 since 1.3 is out & it isn't fixed yet #847

Closed
benatkin opened this issue Jun 30, 2015 · 1 comment
Closed

update comment that says xhr hack is for angular <1.2 since 1.3 is out & it isn't fixed yet #847

benatkin opened this issue Jun 30, 2015 · 1 comment

Comments

@benatkin
Copy link

From https://github.com/danialfarid/ng-file-upload/blob/master/dist/ng-file-upload.js#L12

// fix for angular < 1.2.0

How about pointing to angular/angular.js#1934 instead of showing the angular version?
@danialfarid
Copy link
Owner

The check for instanceof Function is for angular < 1.2.0. The xhr hack is for all angular versions.
But for the whole hack the comment could be added, you could submit a PR if you like

@Frank3K Frank3K mentioned this issue Apr 16, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@benatkin @danialfarid