Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

danger pr failing in windows #224

Closed
tivac opened this issue Apr 14, 2017 · 6 comments · Fixed by #273
Closed

danger pr failing in windows #224

tivac opened this issue Apr 14, 2017 · 6 comments · Fixed by #273

Comments

@tivac
Copy link

tivac commented Apr 14, 2017

> node -v
v7.7.3
> npm ls danger
mithril@1.0.1 C:\Users\Patrick\Documents\Code\mithril.js
`-- danger@0.16.0
> set DEBUG=*
> npm-run danger pr --verbose --repl https://github.com/tivac/mithril.js/pull/3

 danger:runner argv: C:\Program Files\nodejs\node.exe,C:\Users\Patrick\Documents\Code\mithril.js\node_modules\danger\distribution\commands\danger.js,pr,--verbose,--repl,https://github.com/tivac/mithril.js/pull/3 +0ms
  danger:pr executing dangerfile at dangerfile.js +0ms

and then it never goes anywhere. I traced it through the code as far as a I could, it makes it to this line in DangerfileRunner.ts and never continues. The process just stops after a bit.

--verbose and --repl do nothing since it presumably is dying without continuing.

@orta
Copy link
Member

orta commented Apr 14, 2017

ouch, interesting, this came from an update to the jest dependencies aea102d ( in 0.14.2 I started seeing issues with the tests around this, so it can be re-produced )

Perhaps it could be this? jestjs/jest#3079

I wonder if we can try set the no watchman

@tivac
Copy link
Author

tivac commented Apr 14, 2017

I'll try to dig into jest and see where it falls apart I guess.

@tivac
Copy link
Author

tivac commented Apr 14, 2017

I changed my local copy of ./node_modules/danger to set the useWatchman option to false when creating the HasteMap, no luck.

As far as I can tell the transpiled async function never returns the constructed HasteMap, for some reason. I verified that the HasteMap constructor is running, but output gets lost after that.

It's been very difficult to get a debugger able to actually step through any of this though 😞

@orta orta mentioned this issue Apr 15, 2017
11 tasks
@tivac
Copy link
Author

tivac commented May 2, 2017

This is still broken in 0.18.0, fwiw.

@orta
Copy link
Member

orta commented May 2, 2017

Aye, aye, definitely still a blocker on 1.0 - current guess is for me to go through the exact options Jest sets to the haste map and see where danger differentiates.

@orta
Copy link
Member

orta commented May 2, 2017

Also, it's possible that jest 20 comes out and fixes it :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants