Increase Zarr depth limit to 7 directories #984
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwodder
added
patch
Codecov Report
@@ Coverage Diff @@
## master #984 +/- ##
==========================================
+ Coverage 87.52% 87.54% +0.02%
==========================================
Files 64 64
Lines 8104 8104
==========================================
+ Hits 7093 7095 +2
+ Misses 1011 1009 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
yarikoptic
reviewed
Apr 25, 2022
| @@ -75,7 +75,7 @@ | |||
|
|
|||
| #: Regular expression for a valid Dandiset version identifier. This regex is | |||
| #: not anchored. | |||
| VERSION_REGEX = fr"(?:{PUBLISHED_VERSION_REGEX}|draft)" | |||
| VERSION_REGEX = rf"(?:{PUBLISHED_VERSION_REGEX}|draft)" | |||
There was a problem hiding this comment.
curious: is there a difference and/or standardization of the order of r and f?
There was a problem hiding this comment.
There's no practical difference, but the latest version of black prefers rf for some reason.
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #983.