-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
keeping logs cleaner in dedicated directory #971
Conversation
Codecov Report
@@ Coverage Diff @@
## master #971 +/- ##
==========================================
+ Coverage 87.52% 87.55% +0.02%
==========================================
Files 64 64
Lines 8104 8129 +25
==========================================
+ Hits 7093 7117 +24
- Misses 1011 1012 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
replace OS specific paths
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if to be fancy let's be fancy consistently with the logs logging ;)
9a2d233
to
6b51a8b
Compare
@yarikoptic watiting for tests. All fixes suggested seem to be in, except As per https://ppb.chymera.eu/d69110.txt (the Given that this still auto-works, I think we might leave it as |
didn't test on windows if would be storing ok given a mix of |
🚀 PR was released in |
Very minor fix, prevents default logs from unceremoniously cluttering
/var/tmp/
.