Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keeping logs cleaner in dedicated directory #971

Merged
merged 4 commits into from
Apr 25, 2022
Merged

keeping logs cleaner in dedicated directory #971

merged 4 commits into from
Apr 25, 2022

Conversation

TheChymera
Copy link
Contributor

Very minor fix, prevents default logs from unceremoniously cluttering /var/tmp/.

@codecov
Copy link

codecov bot commented Apr 21, 2022

Codecov Report

Merging #971 (9a2d233) into master (2c4dcdd) will increase coverage by 0.02%.
The diff coverage is 100.00%.

❗ Current head 9a2d233 differs from pull request most recent head 6b51a8b. Consider uploading reports for the commit 6b51a8b to get more accurate results

@@            Coverage Diff             @@
##           master     #971      +/-   ##
==========================================
+ Coverage   87.52%   87.55%   +0.02%     
==========================================
  Files          64       64              
  Lines        8104     8129      +25     
==========================================
+ Hits         7093     7117      +24     
- Misses       1011     1012       +1     
Flag Coverage Δ
unittests 87.55% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
dandi/bids_validator_xs.py 93.00% <100.00%> (-0.16%) ⬇️
dandi/tests/test_bids_validator_xs.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c4dcdd...6b51a8b. Read the comment docs.

dandi/bids_validator_xs.py Outdated Show resolved Hide resolved
Copy link
Member

@yarikoptic yarikoptic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

replace OS specific paths

Copy link
Member

@yarikoptic yarikoptic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if to be fancy let's be fancy consistently with the logs logging ;)

dandi/bids_validator_xs.py Outdated Show resolved Hide resolved
dandi/bids_validator_xs.py Outdated Show resolved Hide resolved
dandi/bids_validator_xs.py Outdated Show resolved Hide resolved
@TheChymera TheChymera force-pushed the log-path branch 3 times, most recently from 9a2d233 to 6b51a8b Compare April 22, 2022 22:40
@TheChymera
Copy link
Contributor Author

@yarikoptic watiting for tests. All fixes suggested seem to be in, except /.

As per https://ppb.chymera.eu/d69110.txt (the report_path variable value is returned in between repeated prints of the strings “lulu” and “lala”) I think os.path somehow already fixes this up, though I am not sure where since I don't have windows locally.

Given that this still auto-works, I think we might leave it as / so as to not clutter the string with additional variables for formatting. Alternatively, if you want to make it extra-safe, I can explicitly replace / with os.sep... tough again, that won't actually be doing anything.

@TheChymera TheChymera marked this pull request as ready for review April 25, 2022 06:59
@yarikoptic
Copy link
Member

didn't test on windows if would be storing ok given a mix of \ and / in the path, but let's assume so and proceed

@yarikoptic yarikoptic added the patch Increment the patch version when merged label Apr 25, 2022
@yarikoptic yarikoptic merged commit 7482388 into master Apr 25, 2022
@yarikoptic yarikoptic deleted the log-path branch April 25, 2022 16:40
@github-actions
Copy link

🚀 PR was released in 0.39.3 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants