Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed duplicate, and simplified bids validator tests #965

Merged
merged 1 commit into from
Apr 21, 2022

Conversation

TheChymera
Copy link
Contributor

No description provided.

@TheChymera TheChymera marked this pull request as draft April 20, 2022 13:13
@TheChymera TheChymera linked an issue Apr 20, 2022 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Apr 21, 2022

Codecov Report

Merging #965 (786c22b) into master (00ee4dd) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #965      +/-   ##
==========================================
- Coverage   87.56%   87.52%   -0.04%     
==========================================
  Files          65       64       -1     
  Lines        8104     8104              
==========================================
- Hits         7096     7093       -3     
- Misses       1008     1011       +3     
Flag Coverage Δ
unittests 87.52% <100.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
dandi/tests/test_bids_validator_xs.py 100.00% <100.00%> (ø)
dandi/validate.py 75.00% <0.00%> (-25.00%) ⬇️
dandi/tests/test_utils.py 97.29% <0.00%> (-2.03%) ⬇️
dandi/bids_validator_xs.py 93.16% <0.00%> (-0.36%) ⬇️
dandi/tests/test_dandiarchive.py 100.00% <0.00%> (ø)
dandi/utils.py 81.44% <0.00%> (+0.17%) ⬆️
dandi/dandiarchive.py 84.93% <0.00%> (+1.25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 00ee4dd...786c22b. Read the comment docs.

@TheChymera TheChymera marked this pull request as ready for review April 21, 2022 21:13
@TheChymera
Copy link
Contributor Author

@yarikoptic some minor test simplifications you suggested. Doesn't really affect speed right now, just that the one test that took 30s+ is now broken in two.

@yarikoptic yarikoptic added the tests Add or improve existing tests label Apr 21, 2022
@yarikoptic
Copy link
Member

coolio, thanks! let's proceed. Please in the future do not forge to label the PRs appropriately for the release process: https://github.com/dandi/dandi-cli/blob/HEAD/DEVELOPMENT.md#labelling-pull-requests

@yarikoptic yarikoptic merged commit 2c4dcdd into master Apr 21, 2022
@yarikoptic yarikoptic deleted the test_fixes branch April 21, 2022 22:35
@github-actions
Copy link

🚀 PR was released in 0.39.3 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released tests Add or improve existing tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants